feature #10257 [FrameworkBundle][Console] Load command from DIC after command from bundles. (lyrixx)
This PR was merged into the 2.5-dev branch.
Discussion
----------
[FrameworkBundle][Console] Load command from DIC after command from bundles.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
It's better to load a command from DIC after other one. Because it allow easy
override of default (symfony/assetic/doctrine) command. The end user could do:
# config.yml
services:
assetic.command.dump:
class: SensioLabs\Shim\Assetic\DumpCommand
tags:
- { name: console.command }
**Note**: This is not a new feature... It could be very cool to have it for symfony 2.4 ;)
Commits
-------
34f4ef5
[FrameworkBundle][Console] Load command from DIC after command from bundles.
This commit is contained in:
commit
6e9358a9e9
@ -100,16 +100,16 @@ class Application extends BaseApplication
|
||||
{
|
||||
$container = $this->kernel->getContainer();
|
||||
|
||||
if ($container->hasParameter('console.command.ids')) {
|
||||
foreach ($container->getParameter('console.command.ids') as $id) {
|
||||
$this->add($container->get($id));
|
||||
}
|
||||
}
|
||||
|
||||
foreach ($this->kernel->getBundles() as $bundle) {
|
||||
if ($bundle instanceof Bundle) {
|
||||
$bundle->registerCommands($this);
|
||||
}
|
||||
}
|
||||
|
||||
if ($container->hasParameter('console.command.ids')) {
|
||||
foreach ($container->getParameter('console.command.ids') as $id) {
|
||||
$this->add($container->get($id));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user