From 6f24b0546723d8764d0c4753fbcbe8f567b72588 Mon Sep 17 00:00:00 2001 From: apetitpa Date: Fri, 24 Mar 2017 17:16:55 +0100 Subject: [PATCH] Switch to `empty` native function to check emptiness Switch to `empty` because depending on the PHP version, substr returns '' or false --- .../Component/Validator/Constraints/EmailValidator.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/Validator/Constraints/EmailValidator.php b/src/Symfony/Component/Validator/Constraints/EmailValidator.php index ce42219e26..1a771debf9 100644 --- a/src/Symfony/Component/Validator/Constraints/EmailValidator.php +++ b/src/Symfony/Component/Validator/Constraints/EmailValidator.php @@ -138,7 +138,7 @@ class EmailValidator extends ConstraintValidator */ private function checkMX($host) { - return '' !== $host && checkdnsrr($host, 'MX'); + return !empty($host) && checkdnsrr($host, 'MX'); } /** @@ -150,6 +150,6 @@ class EmailValidator extends ConstraintValidator */ private function checkHost($host) { - return '' !== $host && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA'))); + return !empty($host) && ($this->checkMX($host) || (checkdnsrr($host, 'A') || checkdnsrr($host, 'AAAA'))); } }