diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #27712 [Serializer] CsvEncoder::AS_COLLECTION_KEY constant (ogizanagi) 

This PR was merged into the 4.1 branch.

Discussion
----------

[Serializer] CsvEncoder::AS_COLLECTION_KEY constant

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | no
| New feature?  | not really <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

We use public constants for context options. For 4.1 IMHO as a consistency fix.

Commits
-------

660a456d6f [Serializer] CsvEncoder::AS_COLLECTION_KEY constant
This commit is contained in:
Fabien Potencier 2018-06-25 18:58:35 +02:00
parent e32b9650cb 660a456d6f
commit 6f47d0cedd
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Serializer/Encoder/CsvEncoder.php
View File

@ -28,6 +28,7 @@ class CsvEncoder implements EncoderInterface, DecoderInterface
const KEY_SEPARATOR_KEY = 'csv_key_separator';
const HEADERS_KEY = 'csv_headers';
const ESCAPE_FORMULAS_KEY = 'csv_escape_formulas';
const AS_COLLECTION_KEY = 'as_collection';
private $delimiter;
private $enclosure;
@ -157,7 +158,7 @@ class CsvEncoder implements EncoderInterface, DecoderInterface
}
fclose($handle);
if ($context['as_collection'] ?? false) {
if ($context[self::AS_COLLECTION_KEY] ?? false) {
return $result;
}

2
src/Symfony/Component/Serializer/Tests/Encoder/CsvEncoderTest.php
View File

@ -324,7 +324,7 @@ foo
a
CSV
, 'csv', array('as_collection' => true)));
, 'csv', array(CsvEncoder::AS_COLLECTION_KEY => true)));
}
public function testDecodeToManyRelation()