minor #32849 [TwigBridge] revert added type declarations (xabbuh)
This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBridge] revert added type declarations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Even after the merge the `deps="low"` job still times out. Let's revert and debug the root cause first.
Commits
-------
d18d646113
revert added type declarations
This commit is contained in:
commit
71ba5b0bd0
@ -248,7 +248,7 @@ EOF
|
||||
}
|
||||
}
|
||||
|
||||
private function displayGeneralJson(SymfonyStyle $io, ?string $filter)
|
||||
private function displayGeneralJson(SymfonyStyle $io, $filter)
|
||||
{
|
||||
$decorated = $io->isDecorated();
|
||||
$types = ['functions', 'filters', 'tests', 'globals'];
|
||||
@ -302,7 +302,7 @@ EOF
|
||||
return $loaderPaths;
|
||||
}
|
||||
|
||||
private function getMetadata(string $type, $entity)
|
||||
private function getMetadata($type, $entity)
|
||||
{
|
||||
if ('globals' === $type) {
|
||||
return $entity;
|
||||
@ -358,7 +358,7 @@ EOF
|
||||
}
|
||||
}
|
||||
|
||||
private function getPrettyMetadata(string $type, $entity, bool $decorated)
|
||||
private function getPrettyMetadata($type, $entity, $decorated)
|
||||
{
|
||||
if ('tests' === $type) {
|
||||
return '';
|
||||
|
@ -118,7 +118,7 @@ EOF
|
||||
throw new RuntimeException(sprintf('File or directory "%s" is not readable', $filename));
|
||||
}
|
||||
|
||||
private function validate(string $template, $file)
|
||||
private function validate($template, $file)
|
||||
{
|
||||
$realLoader = $this->twig->getLoader();
|
||||
try {
|
||||
@ -136,7 +136,7 @@ EOF
|
||||
return ['template' => $template, 'file' => $file, 'valid' => true];
|
||||
}
|
||||
|
||||
private function display(InputInterface $input, OutputInterface $output, SymfonyStyle $io, array $files)
|
||||
private function display(InputInterface $input, OutputInterface $output, SymfonyStyle $io, $files)
|
||||
{
|
||||
switch ($input->getOption('format')) {
|
||||
case 'txt':
|
||||
@ -148,7 +148,7 @@ EOF
|
||||
}
|
||||
}
|
||||
|
||||
private function displayTxt(OutputInterface $output, SymfonyStyle $io, array $filesInfo)
|
||||
private function displayTxt(OutputInterface $output, SymfonyStyle $io, $filesInfo)
|
||||
{
|
||||
$errors = 0;
|
||||
|
||||
@ -170,7 +170,7 @@ EOF
|
||||
return min($errors, 1);
|
||||
}
|
||||
|
||||
private function displayJson(OutputInterface $output, array $filesInfo)
|
||||
private function displayJson(OutputInterface $output, $filesInfo)
|
||||
{
|
||||
$errors = 0;
|
||||
|
||||
@ -189,7 +189,7 @@ EOF
|
||||
return min($errors, 1);
|
||||
}
|
||||
|
||||
private function renderException(OutputInterface $output, string $template, Error $exception, string $file = null)
|
||||
private function renderException(OutputInterface $output, $template, Error $exception, $file = null)
|
||||
{
|
||||
$line = $exception->getTemplateLine();
|
||||
|
||||
@ -212,7 +212,7 @@ EOF
|
||||
}
|
||||
}
|
||||
|
||||
private function getContext(string $template, int $line, int $context = 3)
|
||||
private function getContext($template, $line, $context = 3)
|
||||
{
|
||||
$lines = explode("\n", $template);
|
||||
|
||||
|
@ -147,7 +147,7 @@ class TwigDataCollector extends DataCollector implements LateDataCollectorInterf
|
||||
return $this->profile;
|
||||
}
|
||||
|
||||
private function getComputedData(string $index)
|
||||
private function getComputedData($index)
|
||||
{
|
||||
if (null === $this->computed) {
|
||||
$this->computed = $this->computeData($this->getProfile());
|
||||
|
@ -116,7 +116,7 @@ class TranslationDefaultDomainNodeVisitor extends AbstractNodeVisitor
|
||||
/**
|
||||
* @return bool
|
||||
*/
|
||||
private function isNamedArguments(Node $arguments)
|
||||
private function isNamedArguments($arguments)
|
||||
{
|
||||
foreach ($arguments as $name => $node) {
|
||||
if (!\is_int($name)) {
|
||||
|
Reference in New Issue
Block a user