From 73d8470a76780e3b64f0e671d0a2e154b3619d0e Mon Sep 17 00:00:00 2001 From: Benjamin Eberlei Date: Sat, 26 Mar 2011 09:42:45 +0100 Subject: [PATCH] [Form] Fix children implementation, setChildren() is not used, the attribute "fields" is. --- .../Form/Renderer/FormRendererInterface.php | 2 -- .../Component/Form/Renderer/ThemeRenderer.php | 13 ++++--------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/Symfony/Component/Form/Renderer/FormRendererInterface.php b/src/Symfony/Component/Form/Renderer/FormRendererInterface.php index 6b041c890b..1a5a3141f6 100644 --- a/src/Symfony/Component/Form/Renderer/FormRendererInterface.php +++ b/src/Symfony/Component/Form/Renderer/FormRendererInterface.php @@ -18,8 +18,6 @@ interface FormRendererInterface { function setForm(FormInterface $form); - function setChildren(array $renderers); - /** * Has this renderer a specific var? * diff --git a/src/Symfony/Component/Form/Renderer/ThemeRenderer.php b/src/Symfony/Component/Form/Renderer/ThemeRenderer.php index 8174830367..1ab12e6b3b 100644 --- a/src/Symfony/Component/Form/Renderer/ThemeRenderer.php +++ b/src/Symfony/Component/Form/Renderer/ThemeRenderer.php @@ -43,8 +43,6 @@ class ThemeRenderer implements FormRendererInterface, \ArrayAccess */ private $rendered = false; - private $children = array(); - public function __construct(FormThemeFactoryInterface $themeFactory, $template = null) { $this->themeFactory = $themeFactory; @@ -85,11 +83,6 @@ class ThemeRenderer implements FormRendererInterface, \ArrayAccess $this->form = $form; } - public function setChildren(array $renderers) - { - $this->children = $renderers; - } - public function setTemplate($template) { $this->setTheme($this->themeFactory->create($template)); @@ -220,12 +213,14 @@ class ThemeRenderer implements FormRendererInterface, \ArrayAccess public function offsetGet($name) { - return $this->children[$name]; + $this->initialize(); + return $this->vars['fields'][$name]; } public function offsetExists($name) { - return isset($this->children[$name]); + $this->initialize(); + return isset($this->vars['fields'][$name]); } public function offsetSet($name, $value)