From 73dddac4e0aa49e70a7db8d15e0ddda8032d2c18 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Thu, 25 Dec 2014 20:39:31 +0100 Subject: [PATCH] [HttpFoundation] removed wrong HTTP header --- src/Symfony/Component/HttpFoundation/BinaryFileResponse.php | 1 - .../Component/HttpFoundation/Tests/BinaryFileResponseTest.php | 3 --- 2 files changed, 4 deletions(-) diff --git a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php b/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php index 089cdc4c14..164414a323 100644 --- a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php +++ b/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php @@ -170,7 +170,6 @@ class BinaryFileResponse extends Response { $this->headers->set('Content-Length', $this->file->getSize()); $this->headers->set('Accept-Ranges', 'bytes'); - $this->headers->set('Content-Transfer-Encoding', 'binary'); if (!$this->headers->has('Content-Type')) { $this->headers->set('Content-Type', $this->file->getMimeType() ?: 'application/octet-stream'); diff --git a/src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php index cef037fd9b..1afd98759a 100644 --- a/src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php +++ b/src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php @@ -77,7 +77,6 @@ class BinaryFileResponseTest extends ResponseTestCase $response->sendContent(); $this->assertEquals(206, $response->getStatusCode()); - $this->assertEquals('binary', $response->headers->get('Content-Transfer-Encoding')); $this->assertEquals($responseRange, $response->headers->get('Content-Range')); } @@ -113,7 +112,6 @@ class BinaryFileResponseTest extends ResponseTestCase $response->sendContent(); $this->assertEquals(200, $response->getStatusCode()); - $this->assertEquals('binary', $response->headers->get('Content-Transfer-Encoding')); } public function provideFullFileRanges() @@ -144,7 +142,6 @@ class BinaryFileResponseTest extends ResponseTestCase $response->sendContent(); $this->assertEquals(416, $response->getStatusCode()); - $this->assertEquals('binary', $response->headers->get('Content-Transfer-Encoding')); #$this->assertEquals('', $response->headers->get('Content-Range')); }