bug #33834 [Validator] Fix ValidValidator group cascading usage (fancyweb)
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Fix ValidValidator group cascading usage
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
`$this->context->getGroup()` returns `string` or `null`.
`ContextualValidatorInterface::validate()` 3rd argument accepts an array but it must not contain `null` (its contract doesn't allow it). If it does, it will fail in `RecursiveContextualValidator::validateInGroup()` for example because of the `string` scalar type on the `$group` argument. (on 4.4)
Note that in our "common" usage of the `Valid` constraint, the group in its validator will never be `null` because this constraint has a special treatment. However, if this validator is reused in a custom way, it can fail.
Commits
-------
72684b001c
[Validator] Fix ValidValidator group cascading usage
This commit is contained in:
commit
7432601b8e
@ -33,6 +33,6 @@ class ValidValidator extends ConstraintValidator
|
|||||||
$this->context
|
$this->context
|
||||||
->getValidator()
|
->getValidator()
|
||||||
->inContext($this->context)
|
->inContext($this->context)
|
||||||
->validate($value, null, [$this->context->getGroup()]);
|
->validate($value, null, $this->context->getGroup());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user