diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #27100 [Messenger] Late collect & clone messages (ogizanagi)

Browse Source 
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Messenger] Late collect & clone messages

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

eb943619b1 [Messenger] Late collect & clone messages
This commit is contained in:
Samuel ROZE 2018-04-30 18:35:47 +02:00
commit 74aa51507f
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Symfony/Component/Messenger/DataCollector/MessengerDataCollector.php
View File

@ -14,6 +14,7 @@ namespace Symfony\Component\Messenger\DataCollector;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\DataCollector\DataCollector;
use Symfony\Component\HttpKernel\DataCollector\LateDataCollectorInterface;
use Symfony\Component\Messenger\TraceableMessageBus;
/**
@ -21,7 +22,7 @@ use Symfony\Component\Messenger\TraceableMessageBus;
*
* @experimental in 4.1
*/
class MessengerDataCollector extends DataCollector
class MessengerDataCollector extends DataCollector implements LateDataCollectorInterface
{
private $traceableBuses = array();
@ -34,6 +35,14 @@ class MessengerDataCollector extends DataCollector
* {@inheritdoc}
*/
public function collect(Request $request, Response $response, \Exception $exception = null)
{
// Noop. Everything is collected live by the traceable buses & cloned as late as possible.
}
/**
* {@inheritdoc}
*/
public function lateCollect()
{
$this->data = array('messages' => array());

6
src/Symfony/Component/Messenger/Tests/DataCollector/MessengerDataCollectorTest.php
View File

@ -12,8 +12,6 @@
namespace Symfony\Component\Messenger\Tests\DataCollector;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Messenger\DataCollector\MessengerDataCollector;
use Symfony\Component\Messenger\MessageBusInterface;
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
@ -43,7 +41,7 @@ class MessengerDataCollectorTest extends TestCase
$bus->dispatch($message);
$collector->collect(Request::create('/'), new Response());
$collector->lateCollect();
$messages = $collector->getMessages();
$this->assertCount(1, $messages);
@ -120,7 +118,7 @@ DUMP
// Ignore.
}
$collector->collect(Request::create('/'), new Response());
$collector->lateCollect();
$messages = $collector->getMessages();
$this->assertCount(1, $messages);