diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #29421 [TwigBundle] Sync tab navigation css (ro0NL)

Browse Source 
This PR was merged into the 4.2 branch.

Discussion
----------

[TwigBundle] Sync tab navigation css

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css.

This solves tab navigation. Which got broken due dark theming.

Before (hovered 2nd tab)

![image](https://user-images.githubusercontent.com/1047696/49338850-fc309580-f627-11e8-9c15-4e6ffee48b0c.png)

After

![image](https://user-images.githubusercontent.com/1047696/49338828-cf7c7e00-f627-11e8-95a5-6dada5fac319.png)

Commits
-------

d6704bbfb0 [TwigBundle] Sync tab navigation css
This commit is contained in:
Nicolas Grekas 2018-12-02 14:11:12 +01:00
commit 76fc833e8c
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig
View File

@ -84,16 +84,15 @@ thead.sf-toggle-content.sf-toggle-visible, tbody.sf-toggle-content.sf-toggle-vis
.sf-toggle-off .icon-open, .sf-toggle-on .icon-close { display: block; }
.tab-navigation { margin: 0 0 1em 0; padding: 0; }
.tab-navigation li { background: #FFF; border: 1px solid #DDD; color: #444; cursor: pointer; display: inline-block; font-size: 16px; margin: 0 0 0 -1px; padding: .5em .75em; z-index: 1; }
.tab-navigation li:hover { background: #EEE; }
.tab-navigation li.disabled { background: #F5F5F5; color: #999; }
.tab-navigation li.active { background: #666; border-color: #666; color: #FAFAFA; z-index: 1100; }
.tab-navigation li .badge { background-color: #F5F5F5; color: #777; display: inline-block; font-size: 14px; font-weight: bold; margin-left: 8px; min-width: 10px; padding: 1px 6px; text-align: center; }
.tab-navigation li:hover .badge { background: #FAFAFA; color: #777; }
.tab-navigation li.active .badge { background-color: #444; color: #FFF; }
.tab-navigation li .badge.status-warning { background: #A46A1F; color: #FFF; }
.tab-navigation li .badge.status-error { background: #B0413E; color: #FFF; }
.tab-navigation li { background: var(--tab-background); border: 1px solid var(--table-border); color: var(--tab-color); cursor: pointer; display: inline-block; font-size: 16px; margin: 0 0 0 -1px; padding: .5em .75em; z-index: 1; }
.tab-navigation li .badge { background-color: var(--base-1); color: var(--base-4); display: inline-block; font-size: 14px; font-weight: bold; margin-left: 8px; min-width: 10px; padding: 1px 6px; text-align: center; white-space: nowrap; }
.tab-navigation li.disabled { background: var(--tab-disabled-background); color: var(--tab-disabled-color); }
.tab-navigation li.active { background: var(--tab-active-background); color: var(--tab-active-color); z-index: 1100; }
.tab-navigation li.active .badge { background-color: var(--base-5); color: var(--base-2); }
.tab-content > *:first-child { margin-top: 0; }
.tab-navigation li .badge.status-warning { background: var(--color-warning); color: #FFF; }
.tab-navigation li .badge.status-error { background: var(--color-error); color: #FFF; }
.sf-tabs .tab:not(:first-child) { display: none; }
[data-filters] { position: relative; }
[data-filtered] { cursor: pointer; }