diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33702 [Security] remove tests for legacy behavior (xabbuh) 

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Security] remove tests for legacy behavior

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

4e0f034e11 remove tests for legacy behavior
This commit is contained in:
Christian Flothmann 2019-09-25 16:12:03 +02:00
parent ec2afb7b43 4e0f034e11
commit 77e42d87b8
1 changed files with 0 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/Symfony/Component/Security/Core/Tests/Authorization/AccessDecisionManagerTest.php
View File

@ -34,48 +34,6 @@ class AccessDecisionManagerTest extends TestCase
$this->assertSame($expected, $manager->decide($token, ['ROLE_FOO']));
}
/**
* @dataProvider getStrategiesWith2RolesTests
*/
public function testLegacyStrategiesWith2Roles($token, $strategy, $voter, $expected)
{
$manager = new AccessDecisionManager([$voter], $strategy);
$this->assertSame($expected, $manager->decide($token, ['ROLE_FOO', 'ROLE_BAR']));
}
public function getStrategiesWith2RolesTests()
{
$token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock();
return [
[$token, 'affirmative', $this->getVoter(VoterInterface::ACCESS_DENIED), false],
[$token, 'affirmative', $this->getVoter(VoterInterface::ACCESS_GRANTED), true],
[$token, 'consensus', $this->getVoter(VoterInterface::ACCESS_DENIED), false],
[$token, 'consensus', $this->getVoter(VoterInterface::ACCESS_GRANTED), true],
[$token, 'unanimous', $this->getVoterFor2Roles($token, VoterInterface::ACCESS_DENIED, VoterInterface::ACCESS_DENIED), false],
[$token, 'unanimous', $this->getVoterFor2Roles($token, VoterInterface::ACCESS_DENIED, VoterInterface::ACCESS_GRANTED), false],
[$token, 'unanimous', $this->getVoterFor2Roles($token, VoterInterface::ACCESS_GRANTED, VoterInterface::ACCESS_DENIED), false],
[$token, 'unanimous', $this->getVoterFor2Roles($token, VoterInterface::ACCESS_GRANTED, VoterInterface::ACCESS_GRANTED), true],
];
}
protected function getVoterFor2Roles($token, $vote1, $vote2)
{
$voter = $this->getMockBuilder('Symfony\Component\Security\Core\Authorization\Voter\VoterInterface')->getMock();
$voter->expects($this->any())
->method('vote')
->willReturnMap([
[$token, null, ['ROLE_FOO'], $vote1],
[$token, null, ['ROLE_BAR'], $vote2],
])
;
return $voter;
}
public function getStrategyTests()
{
return [