diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #39270 [Inflector] Fix Notice when argument is empty string (moldman) 

This PR was merged into the 4.4 branch.

Discussion
----------

[Inflector] Fix Notice when argument is empty string

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT

Fixing issue when we call `Inflector` with empty string:

```
\Symfony\Component\Inflector\Inflector::singularize('');
```
```
Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363
PHP Notice:  Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363
...
Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363
PHP Notice:  Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363
```

Fix for 5.1 https://github.com/symfony/symfony/pull/39244

Commits
-------

2dfe342452 [Inflector] Fix Notice when argument is empty string
This commit is contained in:
Alexander M. Turek 2020-12-01 18:03:27 +01:00
parent 27127a4bab 2dfe342452
commit 782ee5d1d3
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Component/Inflector/Inflector.php
View File

@ -310,6 +310,7 @@ final class Inflector
* A list of words which should not be inflected, reversed.
*/
private static $uninflected = [
'',
'atad',
'reed',
'kcabdeef',

12
src/Symfony/Component/Inflector/Tests/InflectorTest.php
View File

@ -320,4 +320,16 @@ class InflectorTest extends TestCase
$this->assertEquals($expectedPlural, $plural);
}
public function testPluralizeEmptyString()
{
$plural = Inflector::pluralize('');
$this->assertSame('', $plural);
}
public function testSingularizeEmptyString()
{
$singular = Inflector::singularize('');
$this->assertSame('', $singular);
}
}