diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #32210 [Mailer] Fix timeout type hint (fabpot) 

This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] Fix timeout type hint

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The timeout on a socket is a float, not an integer.

Commits
-------

0e7ed9e45c [Mailer] fixed timeout type hint
This commit is contained in:
Fabien Potencier 2019-06-27 11:07:55 +02:00
parent e55978ada8 0e7ed9e45c
commit 791a2127aa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Mailer/Transport/Smtp/Stream/SocketStream.php
View File

@ -34,14 +34,14 @@ final class SocketStream extends AbstractStream
private $sourceIp;
private $streamContextOptions = [];
public function setTimeout(int $timeout): self
public function setTimeout(float $timeout): self
{
$this->timeout = $timeout;
return $this;
}
public function getTimeout(): int
public function getTimeout(): float
{
return $this->timeout;
}