diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #37687 Fix getTranslationNodeVisitor() return type (dbrekelmans)

Browse Source 
This PR was merged into the 5.2-dev branch.

Discussion
----------

Fix getTranslationNodeVisitor() return type

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37686
| License       | MIT
| Doc PR        | -

When constructing the `TranslationExtension` with any `NodeVisitorInterface` other than `TranslationNodeVisitor`, you will get a type error when calling `getTranslationNodeVisitor()`. This PR fixes that by extracting a new `TranslationNodeVisitorInterface`.

Commits
-------

c1344257f1 Fix getTranslationNodeVisitor() return type
This commit is contained in:
Fabien Potencier 2020-07-31 08:20:27 +02:00
commit 79bc5b7001
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
UPGRADE-5.2.md
View File

@ -16,6 +16,11 @@ TwigBundle
* Deprecated the public `twig` service to private.
TwigBridge
----------
* Changed 2nd argument type of `TranslationExtension::__construct()` to `TranslationNodeVisitor`
Validator
---------

3
src/Symfony/Bridge/Twig/Extension/TranslationExtension.php
View File

@ -18,7 +18,6 @@ use Symfony\Bridge\Twig\TokenParser\TransTokenParser;
use Symfony\Contracts\Translation\TranslatorInterface;
use Symfony\Contracts\Translation\TranslatorTrait;
use Twig\Extension\AbstractExtension;
use Twig\NodeVisitor\NodeVisitorInterface;
use Twig\TwigFilter;
// Help opcache.preload discover always-needed symbols
@ -34,7 +33,7 @@ final class TranslationExtension extends AbstractExtension
private $translator;
private $translationNodeVisitor;
public function __construct(TranslatorInterface $translator = null, NodeVisitorInterface $translationNodeVisitor = null)
public function __construct(TranslatorInterface $translator = null, TranslationNodeVisitor $translationNodeVisitor = null)
{
$this->translator = $translator;
$this->translationNodeVisitor = $translationNodeVisitor;