diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Validator] Allow `ConstraintViolation::__toString()` to expose codes that are not null or emtpy strings

This commit is contained in:
Javier Spagnoletti 2018-11-29 13:40:35 -03:00 committed by Nicolas Grekas
parent 6d1b296403
commit 7bb0fb5cc3
2 changed files with 57 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Validator/ConstraintViolation.php
View File

@ -79,13 +79,13 @@ class ConstraintViolation implements ConstraintViolationInterface
}
$propertyPath = (string) $this->propertyPath;
$code = $this->code;
$code = (string) $this->code;
if ('' !== $propertyPath && '[' !== $propertyPath[0] && '' !== $class) {
$class .= '.';
}
if (!empty($code)) {
if ('' !== $code) {
$code = ' (code '.$code.')';
}

55
src/Symfony/Component/Validator/Tests/ConstraintViolationTest.php
View File

@ -53,4 +53,59 @@ EOF;
$this->assertSame($expected, (string) $violation);
}
public function testToStringHandlesCodes()
{
$violation = new ConstraintViolation(
'42 cannot be used here',
'this is the message template',
array(),
array('some_value' => 42),
'some_value',
null,
null,
0
);
$expected = <<<'EOF'
Array.some_value:
42 cannot be used here (code 0)
EOF;
$this->assertSame($expected, (string) $violation);
}
public function testToStringOmitsEmptyCodes()
{
$expected = <<<'EOF'
Array.some_value:
42 cannot be used here
EOF;
$violation = new ConstraintViolation(
'42 cannot be used here',
'this is the message template',
array(),
array('some_value' => 42),
'some_value',
null,
null,
null
);
$this->assertSame($expected, (string) $violation);
$violation = new ConstraintViolation(
'42 cannot be used here',
'this is the message template',
array(),
array('some_value' => 42),
'some_value',
null,
null,
''
);
$this->assertSame($expected, (string) $violation);
}
}