diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #13225 [Filesystem] enforce umask while testing (nicolas-grekas) 

This PR was merged into the 2.3 branch.

Discussion
----------

[Filesystem] enforce umask while testing

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Having a predictable umask (but not the usual one) should help (TDD for #13222).
When merging in 2.5, the patch should be moved to the new `FilesystemTestCase`

Commits
-------

1e547be [Filesystem] enforce umask while testing
This commit is contained in:
Fabien Potencier 2015-01-03 22:01:25 +01:00
parent 4d56fd077e 1e547bebf4
commit 7d15c1d9db
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
View File

@ -18,6 +18,8 @@ use Symfony\Component\Filesystem\Filesystem;
*/
class FilesystemTest extends \PHPUnit_Framework_TestCase
{
private $umask;
/**
* @var string
*/
@ -47,6 +49,7 @@ class FilesystemTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
$this->umask = umask(0);
$this->filesystem = new Filesystem();
$this->workspace = rtrim(sys_get_temp_dir(), DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.time().rand(0, 1000);
mkdir($this->workspace, 0777, true);
@ -56,6 +59,7 @@ class FilesystemTest extends \PHPUnit_Framework_TestCase
public function tearDown()
{
$this->clean($this->workspace);
umask($this->umask);
}
/**