diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add an entry on json export format

Browse Source
This commit is contained in:
Pascal Montoya 2018-05-03 17:38:34 +02:00
parent bab9d99032
commit 7d9467a319
No known key found for this signature in database
GPG Key ID: 6C8C858C247C9140
2 changed files with 28 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Bridge/Twig/CHANGELOG.md
View File

@ -5,7 +5,7 @@ CHANGELOG
-----
* add a `workflow_metadata` function
* add bundle name suggestion on wrongly overrided templates paths
* add bundle name suggestion on wrongly overridden templates paths
3.4.0
-----

34
src/Symfony/Bridge/Twig/Command/DebugCommand.php
View File

@ -88,8 +88,20 @@ EOF
}
$data['tests'] = array_keys($data['tests']);
$data['loader_paths'] = $this->getLoaderPaths();
if ($wrongBundles = $this->findWrongBundleOverrides()) {
$messages = $this->buildWarningMessages($wrongBundles);
$data['warnings'] = array_reduce(
$messages,
function ($carry, $message) {
$carry[] = $message;
return $carry;
},
array()
);
}
$io->writeln(json_encode($data));
$this->displayAlternatives($this->findWrongBundleOverrides(), $io);
return 0;
}
@ -130,7 +142,13 @@ EOF
array_pop($rows);
$io->section('Loader Paths');
$io->table(array('Namespace', 'Paths'), $rows);
$this->displayAlternatives($this->findWrongBundleOverrides(), $io);
$messages = $this->buildWarningMessages($this->findWrongBundleOverrides());
array_walk(
$messages,
function ($message) use ($io) {
$io->warning(trim($message));
}
);
return 0;
}
@ -293,13 +311,12 @@ EOF
}
if (\count($bundleNames)) {
$loadedBundles = $this->bundlesMetadata;
$notFoundBundles = array_diff_key($bundleNames, $loadedBundles);
$notFoundBundles = array_diff_key($bundleNames, $this->bundlesMetadata);
if (\count($notFoundBundles)) {
$alternatives = array();
foreach ($notFoundBundles as $notFoundBundle => $path) {
$alternatives[$path] = array();
foreach ($loadedBundles as $name => $bundle) {
foreach ($this->bundlesMetadata as $name => $bundle) {
$lev = levenshtein($notFoundBundle, $name);
if ($lev <= \strlen($notFoundBundle) / 3 || false !== strpos($name, $notFoundBundle)) {
$alternatives[$path][] = $name;
@ -312,8 +329,9 @@ EOF
return $alternatives;
}
private function displayAlternatives(array $wrongBundles, SymfonyStyle $io): void
private function buildWarningMessages(array $wrongBundles): array
{
$messages = array();
foreach ($wrongBundles as $path => $alternatives) {
$message = sprintf('Path "%s" not matching any bundle found', $path);
if ($alternatives) {
@ -326,7 +344,9 @@ EOF
}
}
}
$io->warning(trim($message));
$messages[] = $message;
}
return $messages;
}
}