minor #15129 Fix quoting style consistency. (ogizanagi)
This PR was merged into the 2.3 branch.
Discussion
----------
Fix quoting style consistency.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This is a really minor change with reference to [this comment](https://github.com/symfony/symfony/pull/15002#discussion_r32536303).
If it's fine, [those changes](https://github.com/symfony/symfony/compare/symfony:2.7...ogizanagi:fix_quoting_style/2.7) for 2.7 will follow up too.
Commits
-------
57d30f9
Fix quoting style consistency.
This commit is contained in:
commit
7e418fd954
@ -77,7 +77,7 @@ class UniqueEntityValidator extends ConstraintValidator
|
|||||||
$criteria = array();
|
$criteria = array();
|
||||||
foreach ($fields as $fieldName) {
|
foreach ($fields as $fieldName) {
|
||||||
if (!$class->hasField($fieldName) && !$class->hasAssociation($fieldName)) {
|
if (!$class->hasField($fieldName) && !$class->hasAssociation($fieldName)) {
|
||||||
throw new ConstraintDefinitionException(sprintf("The field '%s' is not mapped by Doctrine, so it cannot be validated for uniqueness.", $fieldName));
|
throw new ConstraintDefinitionException(sprintf('The field "%s" is not mapped by Doctrine, so it cannot be validated for uniqueness.', $fieldName));
|
||||||
}
|
}
|
||||||
|
|
||||||
$criteria[$fieldName] = $class->reflFields[$fieldName]->getValue($entity);
|
$criteria[$fieldName] = $class->reflFields[$fieldName]->getValue($entity);
|
||||||
|
@ -123,7 +123,7 @@ class FullTransformer
|
|||||||
|
|
||||||
// handle unimplemented characters
|
// handle unimplemented characters
|
||||||
if (false !== strpos($this->notImplementedChars, $dateChars[0])) {
|
if (false !== strpos($this->notImplementedChars, $dateChars[0])) {
|
||||||
throw new NotImplementedException(sprintf("Unimplemented date character '%s' in format '%s'", $dateChars[0], $this->pattern));
|
throw new NotImplementedException(sprintf('Unimplemented date character "%s" in format "%s"', $dateChars[0], $this->pattern));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -53,7 +53,7 @@ class Route
|
|||||||
foreach ($data as $key => $value) {
|
foreach ($data as $key => $value) {
|
||||||
$method = 'set'.str_replace('_', '', $key);
|
$method = 'set'.str_replace('_', '', $key);
|
||||||
if (!method_exists($this, $method)) {
|
if (!method_exists($this, $method)) {
|
||||||
throw new \BadMethodCallException(sprintf("Unknown property '%s' on annotation '%s'.", $key, get_class($this)));
|
throw new \BadMethodCallException(sprintf('Unknown property "%s" on annotation "%s".', $key, get_class($this)));
|
||||||
}
|
}
|
||||||
$this->$method($value);
|
$this->$method($value);
|
||||||
}
|
}
|
||||||
|
@ -101,7 +101,7 @@ class DigestAuthenticationListener implements ListenerInterface
|
|||||||
|
|
||||||
if ($serverDigestMd5 !== $digestAuth->getResponse()) {
|
if ($serverDigestMd5 !== $digestAuth->getResponse()) {
|
||||||
if (null !== $this->logger) {
|
if (null !== $this->logger) {
|
||||||
$this->logger->debug(sprintf("Expected response: '%s' but received: '%s'; is AuthenticationDao returning clear text passwords?", $serverDigestMd5, $digestAuth->getResponse()));
|
$this->logger->debug(sprintf('Expected response: "%s" but received: "%s"; is AuthenticationDao returning clear text passwords?', $serverDigestMd5, $digestAuth->getResponse()));
|
||||||
}
|
}
|
||||||
|
|
||||||
$this->fail($event, $request, new BadCredentialsException('Incorrect response'));
|
$this->fail($event, $request, new BadCredentialsException('Incorrect response'));
|
||||||
|
Reference in New Issue
Block a user