bug #15706 [framework-bundle] Added support for the 0.0.0.0/0
trusted proxy (zerkms)
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15706).
Discussion
----------
[framework-bundle] Added support for the `0.0.0.0/0` trusted proxy
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
It is relevant to my other PR: https://github.com/symfony/symfony/pull/14690
The original intention was to start accepting `0.0.0.0/0` as a trusted proxy (which is a valid CIDR notation).
The prupose is to allow all requests to be treated as trusted and to eliminate using dirty `['0.0.0.0/1', '128.0.0.0/1']` workaround.
Commits
-------
3188e1b
Added support for the `0.0.0.0/0` trusted proxy
This commit is contained in:
commit
81605dd7c9
@ -52,6 +52,10 @@ class Configuration implements ConfigurationInterface
|
||||
}
|
||||
|
||||
if (false !== strpos($v, '/')) {
|
||||
if ('0.0.0.0/0' === $v) {
|
||||
return false;
|
||||
}
|
||||
|
||||
list($v, $mask) = explode('/', $v, 2);
|
||||
|
||||
if (strcmp($mask, (int) $mask) || $mask < 1 || $mask > (false !== strpos($v, ':') ? 128 : 32)) {
|
||||
|
@ -66,6 +66,7 @@ class ConfigurationTest extends \PHPUnit_Framework_TestCase
|
||||
array(array(), array()),
|
||||
array(array('10.0.0.0/8'), array('10.0.0.0/8')),
|
||||
array(array('::ffff:0:0/96'), array('::ffff:0:0/96')),
|
||||
array(array('0.0.0.0/0'), array('0.0.0.0/0')),
|
||||
);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user