minor #20622 [WebProfilerBundle] Dont use request attributes in RouterController (nicolas-grekas)
This PR was merged into the 2.7 branch.
Discussion
----------
[WebProfilerBundle] Dont use request attributes in RouterController
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
As spotted in #20621, it makes little sense to use request attributes here, and if it were to have, the current code is broken because the returned values here have already been processed by ValueExporter in RequestDataCollector.
Commits
-------
962325a
[WebProfilerBundle] Dont use request attributes in RouterController
This commit is contained in:
commit
821e7bbe7e
@ -87,7 +87,7 @@ class RouterController
|
|||||||
$traceRequest = Request::create(
|
$traceRequest = Request::create(
|
||||||
$request->getPathInfo(),
|
$request->getPathInfo(),
|
||||||
$request->getRequestServer()->get('REQUEST_METHOD'),
|
$request->getRequestServer()->get('REQUEST_METHOD'),
|
||||||
$request->getRequestAttributes()->all(),
|
array(),
|
||||||
$request->getRequestCookies()->all(),
|
$request->getRequestCookies()->all(),
|
||||||
array(),
|
array(),
|
||||||
$request->getRequestServer()->all()
|
$request->getRequestServer()->all()
|
||||||
|
Reference in New Issue
Block a user