diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[HttpFoundation] ResponseHeaderBag::clearCookie now accepts secure/httpOnly

Browse Source
This commit is contained in:
Adrien Brault 2014-06-19 11:53:04 -07:00
parent 71c3a3599c
commit 83f4ac56b1
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php
View File

@ -229,12 +229,14 @@ class ResponseHeaderBag extends HeaderBag
* @param string $name * @param string $name
* @param string $path * @param string $path
* @param string $domain * @param string $domain
* @param bool $secure
* @param bool $httpOnly
* *
* @api * @api
*/ */
public function clearCookie($name, $path = '/', $domain = null) public function clearCookie($name, $path = '/', $domain = null, $secure = false, $httpOnly = true)
{ {
$this->setCookie(new Cookie($name, null, 1, $path, $domain)); $this->setCookie(new Cookie($name, null, 1, $path, $domain, $secure, $httpOnly));
} }
/** /**

9
src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
View File

@ -121,6 +121,15 @@ class ResponseHeaderBagTest extends \PHPUnit_Framework_TestCase
$this->assertContains("Set-Cookie: foo=deleted; expires=".gmdate("D, d-M-Y H:i:s T", time() - 31536001)."; path=/; httponly", explode("\r\n", $bag->__toString())); $this->assertContains("Set-Cookie: foo=deleted; expires=".gmdate("D, d-M-Y H:i:s T", time() - 31536001)."; path=/; httponly", explode("\r\n", $bag->__toString()));
} }
public function testClearCookieSecureNotHttpOnly()
{
$bag = new ResponseHeaderBag(array());
$bag->clearCookie('foo', '/', null, true, false);
$this->assertContains("Set-Cookie: foo=deleted; expires=".gmdate("D, d-M-Y H:i:s T", time() - 31536001)."; path=/; secure", explode("\r\n", $bag->__toString()));
}
public function testReplace() public function testReplace()
{ {
$bag = new ResponseHeaderBag(array()); $bag = new ResponseHeaderBag(array());