diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33585 [Security] Removed unused argument in Test (sstok)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[Security] Removed unused argument in Test

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | n/a

After #32998 there was a minor left over, the `testHandleAuthenticationClearsToken` `$tokenClass` argument is no longer used and can be safely removed.

Commits
-------

7c7422f384 [Security] Removed unused argument in Test
This commit is contained in:
Fabien Potencier 2019-09-16 07:42:33 +02:00
commit 8535416d25
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php
View File

@ -83,7 +83,7 @@ class GuardAuthenticatorHandlerTest extends TestCase
/**
* @dataProvider getTokenClearingTests
*/
public function testHandleAuthenticationClearsToken($tokenClass, $tokenProviderKey, $actualProviderKey)
public function testHandleAuthenticationClearsToken($tokenProviderKey, $actualProviderKey)
{
$this->tokenStorage->expects($this->never())
->method('setToken')
@ -104,10 +104,10 @@ class GuardAuthenticatorHandlerTest extends TestCase
public function getTokenClearingTests()
{
$tests = [];
// correct token class and matching firewall => clear the token
$tests[] = ['Symfony\Component\Security\Guard\Token\PostAuthenticationGuardToken', 'the_firewall_key', 'the_firewall_key'];
$tests[] = ['Symfony\Component\Security\Guard\Token\PostAuthenticationGuardToken', 'the_firewall_key', 'different_key'];
$tests[] = ['Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken', 'the_firewall_key', 'the_firewall_key'];
// matching firewall => clear the token
$tests[] = ['the_firewall_key', 'the_firewall_key'];
$tests[] = ['the_firewall_key', 'different_key'];
$tests[] = ['the_firewall_key', 'the_firewall_key'];
return $tests;
}