diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #27700 [Di] Fix undefined variable found by Php Inspections (EA Ultimate) (kalessil)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[Di] Fix undefined variable found by Php Inspections (EA Ultimate)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a3a9e2ec19 [Di] Fix undefined variable found by Php Inspections (EA Ultimate)
This commit is contained in:
Nicolas Grekas 2018-06-25 11:00:20 +02:00
commit 8633f64ceb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
View File

@ -501,7 +501,7 @@ EOTXT;
// $b = new ServiceB();
// $a = new ServiceA(ServiceB $b);
// $b->setServiceA(ServiceA $a);
if (isset($inlinedDefinition[$definition]) && $this->hasReference($id, array($def->getArguments(), $def->getFactory()))) {
if (isset($inlinedDefinitions[$definition]) && $this->hasReference($id, array($def->getArguments(), $def->getFactory()))) {
throw new ServiceCircularReferenceException($id, array($id));
}