diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[WIP] [Locale] Fixes NumberFormatter tests failing when using ICU 4.8 or 4.8.1

Browse Source
This commit is contained in:
Rui Marinho 2012-03-31 21:16:46 +01:00
parent 0c7b2911bc
commit 8689e9cbf2
2 changed files with 76 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
src/Symfony/Component/Locale/Tests/Stub/StubNumberFormatterTest.php
View File

@ -144,14 +144,6 @@ class StubNumberFormatterTest extends LocaleTestCase
array(-100, 'ALL', '(ALL100)'),
array(1000.12, 'ALL', 'ALL1,000'),
array(100, 'BRL', 'R$100.00'),
array(-100, 'BRL', '(R$100.00)'),
array(1000.12, 'BRL', 'R$1,000.12'),
array(100, 'CRC', '₡100'),
array(-100, 'CRC', '(₡100)'),
array(1000.12, 'CRC', '₡1,000'),
array(100, 'JPY', '¥100'),
array(-100, 'JPY', '(¥100)'),
array(1000.12, 'JPY', '¥1,000'),
@ -159,15 +151,77 @@ class StubNumberFormatterTest extends LocaleTestCase
array(100, 'EUR', '€100.00'),
array(-100, 'EUR', '(€100.00)'),
array(1000.12, 'EUR', '€1,000.12'),
);
}
/**
* @dataProvider formatCurrencyWithCurrencyStyleCostaRicanColonsRoundingProvider
*/
public function testFormatCurrencyWithCurrencyStyleCostaRicanColonsRoundingStub($value, $currency, $symbol, $expected)
{
$formatter = $this->getStubFormatterWithCurrencyStyle();
$this->assertEquals(sprintf($expected, '₡'), $formatter->formatCurrency($value, $currency));
}
/**
* @dataProvider formatCurrencyWithCurrencyStyleCostaRicanColonsRoundingProvider
*/
public function testFormatCurrencyWithCurrencyStyleCostaRicanColonsRoundingIntl($value, $currency, $symbol, $expected)
{
$this->skipIfIntlExtensionIsNotLoaded();
$this->skipIfICUVersionIsTooOld();
$formatter = $this->getIntlFormatterWithCurrencyStyle();
$this->assertEquals(sprintf($expected, $symbol), $formatter->formatCurrency($value, $currency));
}
public function formatCurrencyWithCurrencyStyleCostaRicanColonsRoundingProvider()
{
$crc = $this->isIntlExtensionLoaded() && $this->isSameAsIcuVersion('4.8') ? 'CRC' : '₡';
return array(
array(100, 'CRC', $crc, '%s100'),
array(-100, 'CRC', $crc, '(%s100)'),
array(1000.12, 'CRC', $crc, '%s1,000'),
);
}
/**
* @dataProvider formatCurrencyWithCurrencyStyleBrazilianRealRoundingProvider
*/
public function testFormatCurrencyWithCurrencyStyleBrazilianRealRoundingStub($value, $currency, $symbol, $expected)
{
$formatter = $this->getStubFormatterWithCurrencyStyle();
$this->assertEquals(sprintf($expected, 'R'), $formatter->formatCurrency($value, $currency));
}
/**
* @dataProvider formatCurrencyWithCurrencyStyleBrazilianRealRoundingProvider
*/
public function testFormatCurrencyWithCurrencyStyleBrazilianRealRoundingIntl($value, $currency, $symbol, $expected)
{
$this->skipIfIntlExtensionIsNotLoaded();
$this->skipIfICUVersionIsTooOld();
$formatter = $this->getIntlFormatterWithCurrencyStyle();
$this->assertEquals(sprintf($expected, $symbol), $formatter->formatCurrency($value, $currency));
}
public function formatCurrencyWithCurrencyStyleBrazilianRealRoundingProvider()
{
$brl = $this->isIntlExtensionLoaded() && $this->isSameAsIcuVersion('4.8') ? 'BR' : 'R';
return array(
array(100, 'BRL', $brl, '%s$100.00'),
array(-100, 'BRL', $brl, '(%s$100.00)'),
array(1000.12, 'BRL', $brl, '%s$1,000.12'),
// Rounding checks
array(1000.121, 'BRL', 'R$1,000.12'),
array(1000.123, 'BRL', 'R$1,000.12'),
array(1000.125, 'BRL', 'R$1,000.12'),
array(1000.127, 'BRL', 'R$1,000.13'),
array(1000.129, 'BRL', 'R$1,000.13'),
array(11.50999, 'BRL', 'R$11.51'),
array(11.9999464, 'BRL', 'R$12.00')
array(1000.121, 'BRL', $brl, '%s$1,000.12'),
array(1000.123, 'BRL', $brl, '%s$1,000.12'),
array(1000.125, 'BRL', $brl, '%s$1,000.12'),
array(1000.127, 'BRL', $brl, '%s$1,000.13'),
array(1000.129, 'BRL', $brl, '%s$1,000.13'),
array(11.50999, 'BRL', $brl, '%s$11.51'),
array(11.9999464, 'BRL', $brl, '%s$12.00')
);
}

7
src/Symfony/Component/Locale/Tests/TestCase.php
View File

@ -66,6 +66,13 @@ abstract class TestCase extends \PHPUnit_Framework_TestCase
return $icuVersion >= $version;
}
protected function isSameAsIcuVersion($version) {
$version = $this->normalizeIcuVersion($version);
$icuVersion = $this->normalizeIcuVersion($this->getIntlExtensionIcuVersion());
return $icuVersion === $version;
}
protected function isLowerThanIcuVersion($version)
{
$version = $this->normalizeIcuVersion($version);