diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #14644 [Bridge\Twig] Adding a space between the icon and the error message (zmikael, nicolas-grekas)

Browse Source 
This PR was merged into the 2.6 branch.

Discussion
----------

[Bridge\Twig] Adding a space between the icon and the error message

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14557
| License       | MIT
| Doc PR        |

Commits
-------

d0f6342 [Form] Test for space in AbstractBootstrap3LayoutTest::testErrors
7a1fac2 Adding a space between the icon and the error message
This commit is contained in:
Fabien Potencier 2015-05-15 16:18:15 +02:00
commit 87fa40ee54
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig
View File

@ -231,7 +231,7 @@
{% if form.parent %}<span class="help-block">{% else %}<div class="alert alert-danger">{% endif %}
<ul class="list-unstyled">
{%- for error in errors -%}
<li><span class="glyphicon glyphicon-exclamation-sign"></span>{{ error.message }}</li>
<li><span class="glyphicon glyphicon-exclamation-sign"></span> {{ error.message }}</li>
{%- endfor -%}
</ul>
{% if form.parent %}</span>{% else %}</div>{% endif %}

2
src/Symfony/Bridge/Twig/composer.json
View File

@ -22,7 +22,7 @@
"require-dev": {
"symfony/phpunit-bridge": "~2.7",
"symfony/finder": "~2.3",
"symfony/form": "~2.6,>=2.6.6",
"symfony/form": "~2.6,>=2.6.8",
"symfony/http-kernel": "~2.3",
"symfony/intl": "~2.3",
"symfony/routing": "~2.2",

4
src/Symfony/Component/Form/Tests/AbstractBootstrap3LayoutTest.php
View File

@ -118,12 +118,12 @@ abstract class AbstractBootstrap3LayoutTest extends AbstractLayoutTest
[@class="list-unstyled"]
[
./li
[.="[trans]Error 1[/trans]"]
[.=" [trans]Error 1[/trans]"]
[
./span[@class="glyphicon glyphicon-exclamation-sign"]
]
/following-sibling::li
[.="[trans]Error 2[/trans]"]
[.=" [trans]Error 2[/trans]"]
[
./span[@class="glyphicon glyphicon-exclamation-sign"]
]