From 8bd2bbfb1c863f00cfd6fc7380ae7209fc8509c2 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 30 Nov 2018 18:04:09 +0100 Subject: [PATCH] [DI] fix edge case in InlineServiceDefinitionsPass --- .../Compiler/InlineServiceDefinitionsPass.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php index aa5d6d92fb..56f5feb644 100644 --- a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php +++ b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php @@ -92,6 +92,10 @@ class InlineServiceDefinitionsPass extends AbstractRecursivePass implements Repe return false; } + if (!$graph->hasNode($id)) { + return true; + } + if (!$definition->isShared()) { foreach ($graph->getNode($id)->getInEdges() as $edge) { if ($edge->isWeak()) { @@ -106,10 +110,6 @@ class InlineServiceDefinitionsPass extends AbstractRecursivePass implements Repe return false; } - if (!$graph->hasNode($id)) { - return true; - } - if ($this->currentId == $id) { return false; }