[Form] Fixed: NumberToLocalizedStringTransformer does not accept "NaN" as valid number anymore

This commit is contained in:
Bernhard Schussek 2012-01-28 14:14:56 +01:00
parent aaa9de6563
commit 8c63d6d1e5
2 changed files with 15 additions and 1 deletions

View File

@ -103,6 +103,10 @@ class NumberToLocalizedStringTransformer implements DataTransformerInterface
return null;
}
if ('NaN' === $value) {
throw new TransformationFailedException('"NaN" is not a valid number');
}
$formatter = $this->getNumberFormatter();
$value = $formatter->parse($value);

View File

@ -128,10 +128,20 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
* @expectedException Symfony\Component\Form\Exception\TransformationFailedException
* @link https://github.com/symfony/symfony/issues/3161
*/
public function testReverseTransformExpectsValidNumberFromNan()
public function testReverseTransformDisallowsNaN()
{
$transformer = new NumberToLocalizedStringTransformer();
$transformer->reverseTransform('NaN');
}
/**
* @expectedException Symfony\Component\Form\Exception\TransformationFailedException
*/
public function testReverseTransformDisallowsNaN2()
{
$transformer = new NumberToLocalizedStringTransformer();
$transformer->reverseTransform('nan');
}
}