diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #10245 [DomCrawler] Added support for <area> tags to be treated as links (shamess)

Browse Source 
This PR was merged into the 2.3 branch.

Discussion
----------

[DomCrawler] Added support for <area> tags to be treated as links

The [HTML area tag](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/area) behaves exactly like the `a` tag in that they're both clickable, and if it has a `href` follows a link. The Link class works the same with both tags.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

23acd26 [DomCrawler] Added support for <area> tags to be treated as links
This commit is contained in:
Fabien Potencier 2014-02-12 07:33:07 +01:00
commit 8cd285cd2c
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/DomCrawler/Link.php
View File

@ -12,7 +12,7 @@
namespace Symfony\Component\DomCrawler; namespace Symfony\Component\DomCrawler;
/** /**
* Link represents an HTML link (an HTML a tag). * Link represents an HTML link (an HTML a or area tag).
* *
* @author Fabien Potencier <fabien@symfony.com> * @author Fabien Potencier <fabien@symfony.com>
* *
@ -188,7 +188,7 @@ class Link
*/ */
protected function setNode(\DOMNode $node) protected function setNode(\DOMNode $node)
{ {
if ('a' != $node->nodeName) { if ('a' != $node->nodeName && 'area' != $node->nodeName) {
throw new \LogicException(sprintf('Unable to click on a "%s" tag.', $node->nodeName)); throw new \LogicException(sprintf('Unable to click on a "%s" tag.', $node->nodeName));
} }

12
src/Symfony/Component/DomCrawler/Tests/LinkTest.php
View File

@ -74,6 +74,18 @@ class LinkTest extends \PHPUnit_Framework_TestCase
$this->assertEquals($expected, $link->getUri()); $this->assertEquals($expected, $link->getUri());
} }
/**
* @dataProvider getGetUriTests
*/
public function testGetUriOnArea($url, $currentUri, $expected)
{
$dom = new \DOMDocument();
$dom->loadHTML(sprintf('<html><map><area href="%s" /></map></html>', $url));
$link = new Link($dom->getElementsByTagName('area')->item(0), $currentUri);
$this->assertEquals($expected, $link->getUri());
}
public function getGetUriTests() public function getGetUriTests()
{ {
return array( return array(