do not mock event classes

This commit is contained in:
Christian Flothmann 2021-07-09 12:48:54 +02:00
parent 09814d5548
commit 8da1969afc
12 changed files with 65 additions and 216 deletions

View File

@ -16,6 +16,7 @@ use Symfony\Bridge\Monolog\Processor\ConsoleCommandProcessor;
use Symfony\Component\Console\Command\Command; use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Event\ConsoleEvent; use Symfony\Component\Console\Event\ConsoleEvent;
use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
class ConsoleCommandProcessorTest extends TestCase class ConsoleCommandProcessorTest extends TestCase
{ {
@ -66,10 +67,7 @@ class ConsoleCommandProcessorTest extends TestCase
$input->method('getOptions')->willReturn(self::TEST_OPTIONS); $input->method('getOptions')->willReturn(self::TEST_OPTIONS);
$command = $this->createMock(Command::class); $command = $this->createMock(Command::class);
$command->method('getName')->willReturn(self::TEST_NAME); $command->method('getName')->willReturn(self::TEST_NAME);
$consoleEvent = $this->createMock(ConsoleEvent::class);
$consoleEvent->method('getCommand')->willReturn($command);
$consoleEvent->method('getInput')->willReturn($input);
return $consoleEvent; return new ConsoleEvent($command, $input, $this->createMock(OutputInterface::class));
} }
} }

View File

@ -16,6 +16,7 @@ use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\EventListener\AddRequestFormatsListener; use Symfony\Component\HttpKernel\EventListener\AddRequestFormatsListener;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\HttpKernel\KernelEvents; use Symfony\Component\HttpKernel\KernelEvents;
/** /**
@ -54,7 +55,7 @@ class AddRequestFormatsListenerTest extends TestCase
public function testSetAdditionalFormats() public function testSetAdditionalFormats()
{ {
$request = $this->createMock(Request::class); $request = $this->createMock(Request::class);
$event = $this->getRequestEventMock($request); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$request->expects($this->once()) $request->expects($this->once())
->method('setFormat') ->method('setFormat')
@ -62,14 +63,4 @@ class AddRequestFormatsListenerTest extends TestCase
$this->listener->onKernelRequest($event); $this->listener->onKernelRequest($event);
} }
protected function getRequestEventMock(Request $request)
{
$event = $this->createMock(RequestEvent::class);
$event->expects($this->any())
->method('getRequest')
->willReturn($request);
return $event;
}
} }

View File

@ -26,13 +26,17 @@ class SaveSessionListenerTest extends TestCase
{ {
public function testOnlyTriggeredOnMasterRequest() public function testOnlyTriggeredOnMasterRequest()
{ {
$session = $this->createMock(SessionInterface::class);
$session->expects($this->never())->method('save');
$session->expects($this->any())->method('isStarted')->willReturn(true);
$request = new Request();
$request->setSession($session);
$listener = new SaveSessionListener(); $listener = new SaveSessionListener();
$event = $this->createMock(ResponseEvent::class);
$event->expects($this->once())->method('isMasterRequest')->willReturn(false);
$event->expects($this->never())->method('getRequest');
// sub request // sub request
$listener->onKernelResponse($event); $listener->onKernelResponse(new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::SUB_REQUEST, new Response()));
} }
public function testSessionSaved() public function testSessionSaved()

View File

@ -58,9 +58,7 @@ class SessionListenerTest extends TestCase
$request = new Request(); $request = new Request();
$listener = new SessionListener($container); $listener = new SessionListener($container);
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event->expects($this->exactly(2))->method('isMasterRequest')->willReturn(true);
$event->expects($this->once())->method('getRequest')->willReturn($request);
$listener->onKernelRequest($event); $listener->onKernelRequest($event);

View File

@ -14,6 +14,7 @@ namespace Symfony\Component\Security\Http\Tests\Firewall;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface; use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken; use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
@ -62,14 +63,7 @@ class AbstractPreAuthenticatedListenerTest extends TestCase
->method('getPreAuthenticatedData') ->method('getPreAuthenticatedData')
->willReturn($userCredentials); ->willReturn($userCredentials);
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testHandleWhenAuthenticationFails() public function testHandleWhenAuthenticationFails()
@ -109,14 +103,7 @@ class AbstractPreAuthenticatedListenerTest extends TestCase
->method('getPreAuthenticatedData') ->method('getPreAuthenticatedData')
->willReturn($userCredentials); ->willReturn($userCredentials);
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testHandleWhenAuthenticationFailsWithDifferentToken() public function testHandleWhenAuthenticationFailsWithDifferentToken()
@ -158,12 +145,7 @@ class AbstractPreAuthenticatedListenerTest extends TestCase
->method('getPreAuthenticatedData') ->method('getPreAuthenticatedData')
->willReturn($userCredentials); ->willReturn($userCredentials);
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event); $listener($event);
} }
@ -200,14 +182,7 @@ class AbstractPreAuthenticatedListenerTest extends TestCase
->method('getPreAuthenticatedData') ->method('getPreAuthenticatedData')
->willReturn($userCredentials); ->willReturn($userCredentials);
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testHandleWithAnInvalidSimilarToken() public function testHandleWithAnInvalidSimilarToken()
@ -250,13 +225,6 @@ class AbstractPreAuthenticatedListenerTest extends TestCase
->method('getPreAuthenticatedData') ->method('getPreAuthenticatedData')
->willReturn($userCredentials); ->willReturn($userCredentials);
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
} }

View File

@ -15,6 +15,7 @@ use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface; use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationProviderManager; use Symfony\Component\Security\Core\Authentication\AuthenticationProviderManager;
use Symfony\Component\Security\Core\Authentication\Provider\AuthenticationProviderInterface; use Symfony\Component\Security\Core\Authentication\Provider\AuthenticationProviderInterface;
@ -64,14 +65,7 @@ class BasicAuthenticationListenerTest extends TestCase
$this->createMock(AuthenticationEntryPointInterface::class) $this->createMock(AuthenticationEntryPointInterface::class)
); );
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testHandleWhenAuthenticationFails() public function testHandleWhenAuthenticationFails()
@ -109,19 +103,11 @@ class BasicAuthenticationListenerTest extends TestCase
$authenticationEntryPoint $authenticationEntryPoint
); );
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->once())
->method('setResponse')
->with($this->equalTo($response))
;
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
public function testHandleWithNoUsernameServerParameter() public function testHandleWithNoUsernameServerParameter()
@ -141,14 +127,7 @@ class BasicAuthenticationListenerTest extends TestCase
$this->createMock(AuthenticationEntryPointInterface::class) $this->createMock(AuthenticationEntryPointInterface::class)
); );
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testHandleWithASimilarAuthenticatedToken() public function testHandleWithASimilarAuthenticatedToken()
@ -177,14 +156,7 @@ class BasicAuthenticationListenerTest extends TestCase
$this->createMock(AuthenticationEntryPointInterface::class) $this->createMock(AuthenticationEntryPointInterface::class)
); );
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
public function testItRequiresProviderKey() public function testItRequiresProviderKey()
@ -236,18 +208,10 @@ class BasicAuthenticationListenerTest extends TestCase
$authenticationEntryPoint $authenticationEntryPoint
); );
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->once())
->method('setResponse')
->with($this->equalTo($response))
;
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
} }

View File

@ -15,6 +15,7 @@ use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Http\AccessMapInterface; use Symfony\Component\Security\Http\AccessMapInterface;
use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface; use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
use Symfony\Component\Security\Http\Firewall\ChannelListener; use Symfony\Component\Security\Http\Firewall\ChannelListener;
@ -44,19 +45,12 @@ class ChannelListenerTest extends TestCase
->method('start') ->method('start')
; ;
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->never())
->method('setResponse')
;
$listener = new ChannelListener($accessMap, $entryPoint); $listener = new ChannelListener($accessMap, $entryPoint);
$listener($event); $listener($event);
$this->assertNull($event->getResponse());
} }
public function testHandleWithSecuredRequestAndHttpsChannel() public function testHandleWithSecuredRequestAndHttpsChannel()
@ -82,19 +76,12 @@ class ChannelListenerTest extends TestCase
->method('start') ->method('start')
; ;
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->never())
->method('setResponse')
;
$listener = new ChannelListener($accessMap, $entryPoint); $listener = new ChannelListener($accessMap, $entryPoint);
$listener($event); $listener($event);
$this->assertNull($event->getResponse());
} }
public function testHandleWithNotSecuredRequestAndHttpsChannel() public function testHandleWithNotSecuredRequestAndHttpsChannel()
@ -124,20 +111,12 @@ class ChannelListenerTest extends TestCase
->willReturn($response) ->willReturn($response)
; ;
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->once())
->method('setResponse')
->with($this->equalTo($response))
;
$listener = new ChannelListener($accessMap, $entryPoint); $listener = new ChannelListener($accessMap, $entryPoint);
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
public function testHandleWithSecuredRequestAndHttpChannel() public function testHandleWithSecuredRequestAndHttpChannel()
@ -167,19 +146,11 @@ class ChannelListenerTest extends TestCase
->willReturn($response) ->willReturn($response)
; ;
$event = $this->createMock(RequestEvent::class); $event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$event
->expects($this->once())
->method('setResponse')
->with($this->equalTo($response))
;
$listener = new ChannelListener($accessMap, $entryPoint); $listener = new ChannelListener($accessMap, $entryPoint);
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
} }

View File

@ -146,13 +146,9 @@ class ContextListenerTest extends TestCase
public function testInvalidTokenInSession($token) public function testInvalidTokenInSession($token)
{ {
$tokenStorage = $this->createMock(TokenStorageInterface::class); $tokenStorage = $this->createMock(TokenStorageInterface::class);
$event = $this->createMock(RequestEvent::class);
$request = $this->createMock(Request::class); $request = $this->createMock(Request::class);
$session = $this->createMock(SessionInterface::class); $session = $this->createMock(SessionInterface::class);
$event->expects($this->any())
->method('getRequest')
->willReturn($request);
$request->expects($this->any()) $request->expects($this->any())
->method('hasPreviousSession') ->method('hasPreviousSession')
->willReturn(true); ->willReturn(true);
@ -168,7 +164,7 @@ class ContextListenerTest extends TestCase
->with(null); ->with(null);
$listener = new ContextListener($tokenStorage, [], 'key123'); $listener = new ContextListener($tokenStorage, [], 'key123');
$listener($event); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
} }
public function provideInvalidToken() public function provideInvalidToken()
@ -186,22 +182,13 @@ class ContextListenerTest extends TestCase
{ {
$tokenStorage = $this->createMock(TokenStorageInterface::class); $tokenStorage = $this->createMock(TokenStorageInterface::class);
$dispatcher = $this->createMock(EventDispatcherInterface::class); $dispatcher = $this->createMock(EventDispatcherInterface::class);
$event = $this->createMock(RequestEvent::class);
$listener = new ContextListener($tokenStorage, [], 'key123', null, $dispatcher); $listener = new ContextListener($tokenStorage, [], 'key123', null, $dispatcher);
$event->expects($this->any())
->method('isMasterRequest')
->willReturn(true);
$event->expects($this->any())
->method('getRequest')
->willReturn($this->createMock(Request::class));
$dispatcher->expects($this->once()) $dispatcher->expects($this->once())
->method('addListener') ->method('addListener')
->with(KernelEvents::RESPONSE, [$listener, 'onKernelResponse']); ->with(KernelEvents::RESPONSE, [$listener, 'onKernelResponse']);
$listener($event); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), new Request(), HttpKernelInterface::MASTER_REQUEST));
} }
public function testOnKernelResponseListenerRemovesItself() public function testOnKernelResponseListenerRemovesItself()
@ -234,14 +221,11 @@ class ContextListenerTest extends TestCase
$request = $this->createMock(Request::class); $request = $this->createMock(Request::class);
$request->expects($this->any())->method('hasPreviousSession')->willReturn(false); $request->expects($this->any())->method('hasPreviousSession')->willReturn(false);
$event = $this->createMock(RequestEvent::class);
$event->expects($this->any())->method('getRequest')->willReturn($request);
$tokenStorage = $this->createMock(TokenStorageInterface::class); $tokenStorage = $this->createMock(TokenStorageInterface::class);
$tokenStorage->expects($this->once())->method('setToken')->with(null); $tokenStorage->expects($this->once())->method('setToken')->with(null);
$listener = new ContextListener($tokenStorage, [], 'key123'); $listener = new ContextListener($tokenStorage, [], 'key123');
$listener($event); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
} }
public function testIfTokenIsDeauthenticated() public function testIfTokenIsDeauthenticated()

View File

@ -15,6 +15,7 @@ use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Exception\LogoutException; use Symfony\Component\Security\Core\Exception\LogoutException;
use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface; use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
@ -30,10 +31,8 @@ class LogoutListenerTest extends TestCase
{ {
[$listener, , $httpUtils, $options] = $this->getListener(); [$listener, , $httpUtils, $options] = $this->getListener();
[$event, $request] = $this->getGetResponseEvent(); $request = new Request();
$event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$event->expects($this->never())
->method('setResponse');
$httpUtils->expects($this->once()) $httpUtils->expects($this->once())
->method('checkRequestPath') ->method('checkRequestPath')
@ -41,6 +40,8 @@ class LogoutListenerTest extends TestCase
->willReturn(false); ->willReturn(false);
$listener($event); $listener($event);
$this->assertNull($event->getResponse());
} }
public function testHandleMatchedPathWithSuccessHandlerAndCsrfValidation() public function testHandleMatchedPathWithSuccessHandlerAndCsrfValidation()
@ -50,7 +51,8 @@ class LogoutListenerTest extends TestCase
[$listener, $tokenStorage, $httpUtils, $options] = $this->getListener($successHandler, $tokenManager); [$listener, $tokenStorage, $httpUtils, $options] = $this->getListener($successHandler, $tokenManager);
[$event, $request] = $this->getGetResponseEvent(); $request = new Request();
$event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$request->query->set('_csrf_token', 'token'); $request->query->set('_csrf_token', 'token');
@ -81,13 +83,11 @@ class LogoutListenerTest extends TestCase
->method('setToken') ->method('setToken')
->with(null); ->with(null);
$event->expects($this->once())
->method('setResponse')
->with($response);
$listener->addHandler($handler); $listener->addHandler($handler);
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
public function testHandleMatchedPathWithoutSuccessHandlerAndCsrfValidation() public function testHandleMatchedPathWithoutSuccessHandlerAndCsrfValidation()
@ -96,7 +96,8 @@ class LogoutListenerTest extends TestCase
[$listener, $tokenStorage, $httpUtils, $options] = $this->getListener($successHandler); [$listener, $tokenStorage, $httpUtils, $options] = $this->getListener($successHandler);
[$event, $request] = $this->getGetResponseEvent(); $request = new Request();
$event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$httpUtils->expects($this->once()) $httpUtils->expects($this->once())
->method('checkRequestPath') ->method('checkRequestPath')
@ -121,13 +122,11 @@ class LogoutListenerTest extends TestCase
->method('setToken') ->method('setToken')
->with(null); ->with(null);
$event->expects($this->once())
->method('setResponse')
->with($response);
$listener->addHandler($handler); $listener->addHandler($handler);
$listener($event); $listener($event);
$this->assertSame($response, $event->getResponse());
} }
public function testSuccessHandlerReturnsNonResponse() public function testSuccessHandlerReturnsNonResponse()
@ -137,7 +136,8 @@ class LogoutListenerTest extends TestCase
[$listener, , $httpUtils, $options] = $this->getListener($successHandler); [$listener, , $httpUtils, $options] = $this->getListener($successHandler);
[$event, $request] = $this->getGetResponseEvent(); $request = new Request();
$event = new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST);
$httpUtils->expects($this->once()) $httpUtils->expects($this->once())
->method('checkRequestPath') ->method('checkRequestPath')
@ -159,8 +159,7 @@ class LogoutListenerTest extends TestCase
[$listener, , $httpUtils, $options] = $this->getListener(null, $tokenManager); [$listener, , $httpUtils, $options] = $this->getListener(null, $tokenManager);
[$event, $request] = $this->getGetResponseEvent(); $request = new Request();
$request->query->set('_csrf_token', 'token'); $request->query->set('_csrf_token', 'token');
$httpUtils->expects($this->once()) $httpUtils->expects($this->once())
@ -172,7 +171,7 @@ class LogoutListenerTest extends TestCase
->method('isTokenValid') ->method('isTokenValid')
->willReturn(false); ->willReturn(false);
$listener($event); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
} }
private function getTokenManager() private function getTokenManager()
@ -185,17 +184,6 @@ class LogoutListenerTest extends TestCase
return $this->createMock(TokenStorageInterface::class); return $this->createMock(TokenStorageInterface::class);
} }
private function getGetResponseEvent()
{
$event = $this->createMock(RequestEvent::class);
$event->expects($this->any())
->method('getRequest')
->willReturn($request = new Request());
return [$event, $request];
}
private function getHandler() private function getHandler()
{ {
return $this->createMock(LogoutHandlerInterface::class); return $this->createMock(LogoutHandlerInterface::class);

View File

@ -16,7 +16,6 @@ use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\SessionInterface; use Symfony\Component\HttpFoundation\Session\SessionInterface;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface; use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface; use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
@ -363,11 +362,6 @@ class RememberMeListenerTest extends TestCase
return $event; return $event;
} }
protected function getResponseEvent(): ResponseEvent
{
return $this->createMock(ResponseEvent::class);
}
protected function getListener($withDispatcher = false, $catchExceptions = true, $withSessionStrategy = false) protected function getListener($withDispatcher = false, $catchExceptions = true, $withSessionStrategy = false)
{ {
$listener = new RememberMeListener( $listener = new RememberMeListener(

View File

@ -16,6 +16,7 @@ use Psr\Log\LoggerInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface; use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\RequestEvent; use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\HttpKernelInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationProviderManager; use Symfony\Component\Security\Core\Authentication\AuthenticationProviderManager;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Exception\AuthenticationException; use Symfony\Component\Security\Core\Exception\AuthenticationException;
@ -110,12 +111,7 @@ class SimplePreAuthenticationListenerTest extends TestCase
$this->request = new Request([], [], [], [], [], []); $this->request = new Request([], [], [], [], [], []);
$this->event = $this->createMock(RequestEvent::class); $this->event = new RequestEvent($this->createMock(HttpKernelInterface::class), $this->request, HttpKernelInterface::MASTER_REQUEST);
$this->event
->expects($this->any())
->method('getRequest')
->willReturn($this->request)
;
$this->logger = $this->createMock(LoggerInterface::class); $this->logger = $this->createMock(LoggerInterface::class);
$this->tokenStorage = $this->createMock(TokenStorageInterface::class); $this->tokenStorage = $this->createMock(TokenStorageInterface::class);

View File

@ -78,14 +78,7 @@ class UsernamePasswordFormAuthenticationListenerTest extends TestCase
['require_previous_session' => false] ['require_previous_session' => false]
); );
$event = $this->createMock(RequestEvent::class); $listener(new RequestEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MASTER_REQUEST));
$event
->expects($this->any())
->method('getRequest')
->willReturn($request)
;
$listener($event);
} }
/** /**