diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SCA: minor code tweaks

Browse Source
This commit is contained in:
vladimir.reznichenko 2018-10-26 15:40:38 +02:00
parent 4877d60a74
commit 8dbd927a33
5 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View File

@ -881,12 +881,9 @@ class FrameworkExtension extends Extension
if ($config['formats']) { if ($config['formats']) {
$loader->load('request.xml'); $loader->load('request.xml');
$container->getDefinition('request.add_request_formats_listener')->setPrivate(true); $listener = $container->getDefinition('request.add_request_formats_listener');
$listener->setPrivate(true);
$container $listener->replaceArgument(0, $config['formats']);
->getDefinition('request.add_request_formats_listener')
->replaceArgument(0, $config['formats'])
;
} }
} }

2
src/Symfony/Component/Config/Util/XmlUtils.php
View File

@ -240,7 +240,7 @@ class XmlUtils
return '0x' === $value[0].$value[1] ? hexdec($value) : (float) $value; return '0x' === $value[0].$value[1] ? hexdec($value) : (float) $value;
case preg_match('/^0x[0-9a-f]++$/i', $value): case preg_match('/^0x[0-9a-f]++$/i', $value):
return hexdec($value); return hexdec($value);
case preg_match('/^(-|\+)?[0-9]+(\.[0-9]+)?$/', $value): case preg_match('/^[+-]?[0-9]+(\.[0-9]+)?$/', $value):
return (float) $value; return (float) $value;
default: default:
return $value; return $value;

4
src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php
View File

@ -635,8 +635,8 @@ class XmlFileLoaderTest extends TestCase
$resources = $container->getResources(); $resources = $container->getResources();
$fixturesDir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR; $fixturesDir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR;
$this->assertTrue(false !== array_search(new FileResource($fixturesDir.'xml'.\DIRECTORY_SEPARATOR.'services_prototype.xml'), $resources)); $this->assertContains(new FileResource($fixturesDir . 'xml' . \DIRECTORY_SEPARATOR . 'services_prototype.xml'), $resources);
$this->assertTrue(false !== array_search(new GlobResource($fixturesDir.'Prototype', '/*', true), $resources)); $this->assertContains(new GlobResource($fixturesDir . 'Prototype', '/*', true), $resources);
$resources = array_map('strval', $resources); $resources = array_map('strval', $resources);
$this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Foo', $resources); $this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Foo', $resources);
$this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Sub\Bar', $resources); $this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Sub\Bar', $resources);

4
src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php
View File

@ -394,8 +394,8 @@ class YamlFileLoaderTest extends TestCase
$resources = $container->getResources(); $resources = $container->getResources();
$fixturesDir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR; $fixturesDir = \dirname(__DIR__).\DIRECTORY_SEPARATOR.'Fixtures'.\DIRECTORY_SEPARATOR;
$this->assertTrue(false !== array_search(new FileResource($fixturesDir.'yaml'.\DIRECTORY_SEPARATOR.'services_prototype.yml'), $resources)); $this->assertContains(new FileResource($fixturesDir . 'yaml' . \DIRECTORY_SEPARATOR . 'services_prototype.yml'), $resources);
$this->assertTrue(false !== array_search(new GlobResource($fixturesDir.'Prototype', '', true), $resources)); $this->assertContains(new GlobResource($fixturesDir . 'Prototype', '', true), $resources);
$resources = array_map('strval', $resources); $resources = array_map('strval', $resources);
$this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Foo', $resources); $this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Foo', $resources);
$this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Sub\Bar', $resources); $this->assertContains('reflection.Symfony\Component\DependencyInjection\Tests\Fixtures\Prototype\Sub\Bar', $resources);

2
src/Symfony/Component/HttpFoundation/Response.php
View File

@ -974,7 +974,7 @@ class Response
public function setCache(array $options) public function setCache(array $options)
{ {
if ($diff = array_diff(array_keys($options), array('etag', 'last_modified', 'max_age', 's_maxage', 'private', 'public', 'immutable'))) { if ($diff = array_diff(array_keys($options), array('etag', 'last_modified', 'max_age', 's_maxage', 'private', 'public', 'immutable'))) {
throw new \InvalidArgumentException(sprintf('Response does not support the following options: "%s".', implode('", "', array_values($diff)))); throw new \InvalidArgumentException(sprintf('Response does not support the following options: "%s".', implode('", "', $diff)));
} }
if (isset($options['etag'])) { if (isset($options['etag'])) {