From 8dd0c5641a5b046324d129a993f199e51bdceadf Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sun, 30 Jan 2011 15:07:02 +0100 Subject: [PATCH] [HttpFoundation] made small optimizations --- src/Symfony/Component/HttpFoundation/HeaderBag.php | 5 ++++- src/Symfony/Component/HttpFoundation/ParameterBag.php | 2 +- src/Symfony/Component/HttpFoundation/Request.php | 6 +++++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/Symfony/Component/HttpFoundation/HeaderBag.php b/src/Symfony/Component/HttpFoundation/HeaderBag.php index 0ccbc9a9e2..da3692dab5 100644 --- a/src/Symfony/Component/HttpFoundation/HeaderBag.php +++ b/src/Symfony/Component/HttpFoundation/HeaderBag.php @@ -31,7 +31,10 @@ class HeaderBag { $this->cacheControl = array(); $this->cookies = array(); - $this->replace($headers); + $this->headers = array(); + foreach ($headers as $key => $values) { + $this->set($key, $values); + } } /** diff --git a/src/Symfony/Component/HttpFoundation/ParameterBag.php b/src/Symfony/Component/HttpFoundation/ParameterBag.php index f427d1320c..895c7ee8e3 100644 --- a/src/Symfony/Component/HttpFoundation/ParameterBag.php +++ b/src/Symfony/Component/HttpFoundation/ParameterBag.php @@ -27,7 +27,7 @@ class ParameterBag */ public function __construct(array $parameters = array()) { - $this->replace($parameters); + $this->parameters = $parameters; } /** diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php index ac41a2c2fd..fded6a65bc 100644 --- a/src/Symfony/Component/HttpFoundation/Request.php +++ b/src/Symfony/Component/HttpFoundation/Request.php @@ -511,7 +511,11 @@ class Request $host = trim($elements[count($elements) - 1]); } else { - $host = $this->headers->get('HOST', $this->server->get('SERVER_NAME', $this->server->get('SERVER_ADDR', ''))); + if (!$host = $this->headers->get('HOST')) { + if (!$host = $this->server->get('SERVER_NAME')) { + $host = $this->server->get('SERVER_ADDR', ''); + } + } } // Remove port number from host