diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #12191 [Security] More accurate docblocks for AbstractVoter (johnkary)

Browse Source 
This PR was squashed before being merged into the 2.6-dev branch (closes #12191).

Discussion
----------

[Security] More accurate docblocks for AbstractVoter

| Q             | A
| ------------- | ---
| Fixed tickets | none
| License       | MIT

Two fixes for docblocks in AbstractVoter:

1. Previously the example return value for a few methods used PHP's short array syntax (>= PHP 5.4). Symfony minimum PHP is 5.3 so the docblock examples should be compatible with that.

2. Previously getSupportedClasses() docblock had an example return value showing a FQCN using a leading slash. AbstractVoter looks for `get_class($object)` in the array of getSupportedClasses() returned values, and `get_class()` returns the FQCN without a leading slash.

Commits
-------

ed226ec [Security] More accurate docblocks for AbstractVoter
This commit is contained in:
Fabien Potencier 2014-10-10 18:59:55 +02:00
commit 8e42756c37
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Security/Core/Authorization/Voter/AbstractVoter.php
View File

@ -85,14 +85,14 @@ abstract class AbstractVoter implements VoterInterface
/**
* Return an array of supported classes. This will be called by supportsClass
*
* @return array an array of supported classes, i.e. ['\Acme\DemoBundle\Model\Product']
* @return array an array of supported classes, i.e. array('Acme\DemoBundle\Model\Product')
*/
abstract protected function getSupportedClasses();
/**
* Return an array of supported attributes. This will be called by supportsAttribute
*
* @return array an array of supported attributes, i.e. ['CREATE', 'READ']
* @return array an array of supported attributes, i.e. array('CREATE', 'READ')
*/
abstract protected function getSupportedAttributes();