bug #34076 [HttpKernel] Avoid nested exceptions if errors occur when generating file links (yceruto)
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Avoid nested exceptions if errors occur when generating file links | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Multiple exceptions are fired until the fallback error page is rendered without the FileLinkFormatter:48282ce80f/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php (L79-L86)
**Before** (the reproducer is highlighted inside the picture or simply adds an undefined option to the `@Route()` annotation) ![error-page-before](https://user-images.githubusercontent.com/2028198/67356903-c8a17700-f529-11e9-9384-12a29e17b682.png) **After** (I couldn't find a better solution to display this exception once) ![error-page-after](https://user-images.githubusercontent.com/2028198/67356941-db1bb080-f529-11e9-8808-d7f72dadc4d6.png) Commits -------d91a5a067d
Avoid nested exceptions if errors occur when generating file links
This commit is contained in:
commit
8eb17aa203
@ -13,7 +13,6 @@ namespace Symfony\Component\HttpKernel\Debug;
|
|||||||
|
|
||||||
use Symfony\Component\HttpFoundation\Request;
|
use Symfony\Component\HttpFoundation\Request;
|
||||||
use Symfony\Component\HttpFoundation\RequestStack;
|
use Symfony\Component\HttpFoundation\RequestStack;
|
||||||
use Symfony\Component\Routing\Exception\ExceptionInterface;
|
|
||||||
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
|
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@ -80,7 +79,7 @@ class FileLinkFormatter
|
|||||||
{
|
{
|
||||||
try {
|
try {
|
||||||
return $router->generate($routeName).$queryString;
|
return $router->generate($routeName).$queryString;
|
||||||
} catch (ExceptionInterface $e) {
|
} catch (\Throwable $e) {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user