diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Serializer][XmlEncoder] add CDATA padding only if necessary

Browse Source 
Changed XML encoder so CDATA padding is only added to value if necessary.
This commit is contained in:
Manuel Reinhard 2012-01-17 10:51:09 +01:00
parent 3e9d937eb8
commit 90abc0f454
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
View File

@ -304,6 +304,21 @@ class XmlEncoder extends SerializerAwareEncoder implements EncoderInterface, Dec
return $appendNode;
}
/**
* Checks if a value contains any characters which would require CDATA padding.
*
* @param string $val
*
* @return Boolean
*/
private function needsCdataPadding($val)
{
return preg_match('/[<>&]/', $val);
}
/**
* Tests the value being passed and decide what sort of element to create
*
@ -325,8 +340,10 @@ class XmlEncoder extends SerializerAwareEncoder implements EncoderInterface, Dec
return $this->buildXml($node, $this->serializer->normalize($val, $this->format));
} elseif (is_numeric($val)) {
return $this->appendText($node, (string) $val);
} elseif (is_string($val)) {
} elseif (is_string($val) && $this->needsCdataPadding($val)) {
return $this->appendCData($node, $val);
} elseif (is_string($val)) {
return $this->appendText($node, $val);
} elseif (is_bool($val)) {
return $this->appendText($node, (int) $val);
} elseif ($val instanceof \DOMNode) {