From 91f1680b3fc8347e84ec2df8dbbfd893eb47cc2e Mon Sep 17 00:00:00 2001
From: Tobias Nyholm <tobias.nyholm@gmail.com>
Date: Thu, 13 Jun 2019 14:57:18 +0200
Subject: [PATCH] [Messenger] Remove DispatchAfterCurrentBusStamp when message
 is put on internal queue

---
 .../DispatchAfterCurrentBusMiddleware.php     |  2 +-
 .../DispatchAfterCurrentBusMiddlewareTest.php | 47 +++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php b/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php
index 4c098c79b7..19c714d1b8 100644
--- a/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php
+++ b/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php
@@ -112,7 +112,7 @@ final class QueuedEnvelope
 
     public function __construct(Envelope $envelope, StackInterface $stack)
     {
-        $this->envelope = $envelope;
+        $this->envelope = $envelope->withoutAll(DispatchAfterCurrentBusStamp::class);
         $this->stack = $stack;
     }
 
diff --git a/src/Symfony/Component/Messenger/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php b/src/Symfony/Component/Messenger/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php
index f2217affda..fe6d190c10 100644
--- a/src/Symfony/Component/Messenger/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php
+++ b/src/Symfony/Component/Messenger/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php
@@ -99,6 +99,53 @@ class DispatchAfterCurrentBusMiddlewareTest extends TestCase
         $messageBus->dispatch($message);
     }
 
+    public function testHandleDelayedEventFromQueue()
+    {
+        $message = new DummyMessage('Hello');
+        $event = new DummyEvent('Event on queue');
+
+        $middleware = new DispatchAfterCurrentBusMiddleware();
+        $commandHandlingMiddleware = $this->createMock(MiddlewareInterface::class);
+        $eventHandlingMiddleware = $this->createMock(MiddlewareInterface::class);
+
+        // This bus simulates the bus that are used when messages come back form the queue
+        $messageBusAfterQueue = new MessageBus([
+            // Create a new middleware
+            new DispatchAfterCurrentBusMiddleware(),
+            $eventHandlingMiddleware,
+        ]);
+
+        $fakePutMessageOnQueue = $this->createMock(MiddlewareInterface::class);
+        $fakePutMessageOnQueue->expects($this->any())
+            ->method('handle')
+            ->with($this->callback(function ($envelope) use ($messageBusAfterQueue) {
+                // Fake putting the message on the queue
+                // Fake reading the queue
+                // Now, we add the message back to a new bus.
+                $messageBusAfterQueue->dispatch($envelope);
+
+                return true;
+            }))
+            ->willReturnArgument(0);
+
+        $eventBus = new MessageBus([
+            $middleware,
+            $fakePutMessageOnQueue,
+        ]);
+
+        $messageBus = new MessageBus([
+            $middleware,
+            new DispatchingMiddleware($eventBus, [
+                new Envelope($event, [new DispatchAfterCurrentBusStamp()]),
+            ]),
+            $commandHandlingMiddleware,
+        ]);
+
+        $this->expectHandledMessage($commandHandlingMiddleware, 0, $message);
+        $this->expectHandledMessage($eventHandlingMiddleware, 0, $event);
+        $messageBus->dispatch($message);
+    }
+
     /**
      * @param MiddlewareInterface|MockObject $handlingMiddleware
      */