diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure the parent process is always killed

Browse Source 
If you try to run the test suite but do not have a redis instance
running, the parent process that was supposed to be killed will never be
as the thing being thrown is not an exception.
This results in the test suite hanging forever at the end.
In this patch, the exception is thrown again, and then caught in the trait, and
the parent gets killed as it should.
This commit is contained in:
Grégoire Paris 2019-04-06 11:47:31 +02:00
parent 25db9e26c9
commit 94d41825fd
No known key found for this signature in database
GPG Key ID: 6CE0C6A7B0858F70
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Lock/Tests/Store/BlockingStoreTestTrait.php
View File

@ -74,8 +74,8 @@ trait BlockingStoreTestTrait
// Block SIGHUP signal
pcntl_sigprocmask(SIG_BLOCK, [SIGHUP]);
$store = $this->getStore();
try {
$store = $this->getStore();
$store->save($key);
// send the ready signal to the parent
posix_kill($parentPID, SIGHUP);
@ -87,7 +87,8 @@ trait BlockingStoreTestTrait
usleep($clockDelay);
$store->delete($key);
exit(0);
} catch (\Exception $e) {
} catch (\Throwable $e) {
posix_kill($parentPID, SIGHUP);
exit(1);
}
}