From 95fb929c5877c03dc17b4a38e266c2c39249369b Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 24 May 2017 10:44:44 +0200 Subject: [PATCH] [DI] Add missing deprecation on Extension::getClassesToCompile --- UPGRADE-3.3.md | 2 +- UPGRADE-4.0.md | 2 +- src/Symfony/Component/HttpKernel/CHANGELOG.md | 2 +- .../Component/HttpKernel/DependencyInjection/Extension.php | 6 ++++++ 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/UPGRADE-3.3.md b/UPGRADE-3.3.md index 3734fff5e2..c068b378f5 100644 --- a/UPGRADE-3.3.md +++ b/UPGRADE-3.3.md @@ -266,7 +266,7 @@ HttpKernel * Deprecated the `Kernel::getRootDir()` method. Use the new `Kernel::getProjectDir()` method instead. - * The `Extension::addClassesToCompile()` method has been deprecated and will be removed in 4.0. + * The `Extension::addClassesToCompile()` and `Extension::getClassesToCompile()` methods have been deprecated and will be removed in 4.0. * The `Psr6CacheClearer::addPool()` method has been deprecated. Pass an array of pools indexed by name to the constructor instead. diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md index 0f89d2b3b7..1191c074ae 100644 --- a/UPGRADE-4.0.md +++ b/UPGRADE-4.0.md @@ -376,7 +376,7 @@ HttpKernel * Removed the `Kernel::getRootDir()` method. Use the `Kernel::getProjectDir()` method instead. - * The `Extension::addClassesToCompile()` method has been removed. + * The `Extension::addClassesToCompile()` and `Extension::getClassesToCompile()` methods have been removed. * Possibility to pass non-scalar values as URI attributes to the ESI and SSI renderers has been removed. The inline fragment renderer should be used with diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md index b963960fe0..061f61d172 100644 --- a/src/Symfony/Component/HttpKernel/CHANGELOG.md +++ b/src/Symfony/Component/HttpKernel/CHANGELOG.md @@ -10,7 +10,7 @@ CHANGELOG * deprecated the special `SYMFONY__` environment variables * added the possibility to change the query string parameter used by `UriSigner` * deprecated `LazyLoadingFragmentHandler::addRendererService()` - * deprecated `Extension::addClassesToCompile()` + * deprecated `Extension::addClassesToCompile()` and `Extension::getClassesToCompile()` * deprecated `Psr6CacheClearer::addPool()` 3.2.0 diff --git a/src/Symfony/Component/HttpKernel/DependencyInjection/Extension.php b/src/Symfony/Component/HttpKernel/DependencyInjection/Extension.php index 99ae0d4b90..573e1b4e6b 100644 --- a/src/Symfony/Component/HttpKernel/DependencyInjection/Extension.php +++ b/src/Symfony/Component/HttpKernel/DependencyInjection/Extension.php @@ -27,9 +27,15 @@ abstract class Extension extends BaseExtension * Gets the classes to cache. * * @return array An array of classes + * + * @deprecated since version 3.3, to be removed in 4.0. */ public function getClassesToCompile() { + if (PHP_VERSION_ID >= 70000) { + @trigger_error(__METHOD__.'() is deprecated since version 3.3, to be removed in 4.0.', E_USER_DEPRECATED); + } + return $this->classes; }