diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

return false early from directory resource

Browse Source
This commit is contained in:
Rob Frawley 2nd 2017-01-29 16:51:59 -05:00
parent f7ba71db7c
commit 96107e21f1
No known key found for this signature in database
GPG Key ID: 0EC41426CA2BA4E4
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Symfony/Component/Config/Resource/DirectoryResource.php
View File

@ -68,7 +68,10 @@ class DirectoryResource implements ResourceInterface, \Serializable
return false; return false;
} }
$newestMTime = filemtime($this->resource); if ($timestamp <= filemtime($this->resource)) {
return false;
}
foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($this->resource), \RecursiveIteratorIterator::SELF_FIRST) as $file) { foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($this->resource), \RecursiveIteratorIterator::SELF_FIRST) as $file) {
// if regex filtering is enabled only check matching files // if regex filtering is enabled only check matching files
if ($this->pattern && $file->isFile() && !preg_match($this->pattern, $file->getBasename())) { if ($this->pattern && $file->isFile() && !preg_match($this->pattern, $file->getBasename())) {
@ -81,10 +84,13 @@ class DirectoryResource implements ResourceInterface, \Serializable
continue; continue;
} }
$newestMTime = max($file->getMTime(), $newestMTime); // early return if a file's mtime exceeds the passed timestamp
if ($timestamp <= $file->getMTime()) {
return false;
}
} }
return $newestMTime < $timestamp; return true;
} }
public function serialize() public function serialize()