diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #14661 [Console] Remove a useless assert in QuestionHelperTest (ogizanagi)

Browse Source 
This PR was merged into the 2.6 branch.

Discussion
----------

[Console] Remove a useless assert in QuestionHelperTest

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This assert was pretty useless, as it is unreachable under expected circumstances, and does not bring anything to this test purpose otherwise.

Commits
-------

55b2361 [Console] Remove a useless assert in QuestionHelperTest
This commit is contained in:
Fabien Potencier 2015-05-16 15:28:59 +02:00
commit 991eec1e1e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
View File

@ -191,7 +191,7 @@ class QuestionHelperTest extends \PHPUnit_Framework_TestCase
$dialog->setInputStream($this->getInputStream("green\nyellow\norange\n"));
try {
$this->assertEquals('white', $dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question));
$dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question);
$this->fail();
} catch (\InvalidArgumentException $e) {
$this->assertEquals($error, $e->getMessage());