minor #14661 [Console] Remove a useless assert in QuestionHelperTest (ogizanagi)
This PR was merged into the 2.6 branch.
Discussion
----------
[Console] Remove a useless assert in QuestionHelperTest
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This assert was pretty useless, as it is unreachable under expected circumstances, and does not bring anything to this test purpose otherwise.
Commits
-------
55b2361
[Console] Remove a useless assert in QuestionHelperTest
This commit is contained in:
commit
991eec1e1e
@ -191,7 +191,7 @@ class QuestionHelperTest extends \PHPUnit_Framework_TestCase
|
|||||||
|
|
||||||
$dialog->setInputStream($this->getInputStream("green\nyellow\norange\n"));
|
$dialog->setInputStream($this->getInputStream("green\nyellow\norange\n"));
|
||||||
try {
|
try {
|
||||||
$this->assertEquals('white', $dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question));
|
$dialog->ask($this->createInputInterfaceMock(), $this->createOutputInterface(), $question);
|
||||||
$this->fail();
|
$this->fail();
|
||||||
} catch (\InvalidArgumentException $e) {
|
} catch (\InvalidArgumentException $e) {
|
||||||
$this->assertEquals($error, $e->getMessage());
|
$this->assertEquals($error, $e->getMessage());
|
||||||
|
Reference in New Issue
Block a user