From 9dcc9facf025eb8043503987431af4b3bfe46a0f Mon Sep 17 00:00:00 2001 From: Tobias Schultze Date: Tue, 14 May 2013 18:18:10 +0200 Subject: [PATCH] [Console] fix abstract Output class that fasly claims to support guessing of decorated variable. Also we don't need to typecast to boolean as its already done by the formatter and its his responsibility --- src/Symfony/Component/Console/Output/Output.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Component/Console/Output/Output.php b/src/Symfony/Component/Console/Output/Output.php index ec0290e378..dd7dbe0f5b 100644 --- a/src/Symfony/Component/Console/Output/Output.php +++ b/src/Symfony/Component/Console/Output/Output.php @@ -36,16 +36,16 @@ abstract class Output implements OutputInterface * Constructor. * * @param integer $verbosity The verbosity level (self::VERBOSITY_QUIET, self::VERBOSITY_NORMAL, self::VERBOSITY_VERBOSE) - * @param Boolean $decorated Whether to decorate messages or not (null for auto-guessing) + * @param Boolean $decorated Whether to decorate messages or not * @param OutputFormatterInterface $formatter Output formatter instance * * @api */ - public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, OutputFormatterInterface $formatter = null) + public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = false, OutputFormatterInterface $formatter = null) { $this->verbosity = null === $verbosity ? self::VERBOSITY_NORMAL : $verbosity; $this->formatter = null === $formatter ? new OutputFormatter() : $formatter; - $this->formatter->setDecorated((Boolean) $decorated); + $this->formatter->setDecorated($decorated); } /** @@ -81,7 +81,7 @@ abstract class Output implements OutputInterface */ public function setDecorated($decorated) { - $this->formatter->setDecorated((Boolean) $decorated); + $this->formatter->setDecorated($decorated); } /**