diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Regression test for missing controller arguments (3.1)

Browse Source
This commit is contained in:
Iltar van der Berg 2016-12-05 09:10:32 +01:00
parent b699e4b77b
commit 9e588b8d96
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/DefaultValueResolver.php
View File

@ -27,7 +27,7 @@ final class DefaultValueResolver implements ArgumentValueResolverInterface
*/
public function supports(Request $request, ArgumentMetadata $argument)
{
return $argument->hasDefaultValue() || ($argument->isNullable() && !$argument->isVariadic());
return $argument->hasDefaultValue() || (null !== $argument->getType() && $argument->isNullable() && !$argument->isVariadic());
}
/**

11
src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolverTest.php
View File

@ -203,6 +203,17 @@ class ArgumentResolverTest extends \PHPUnit_Framework_TestCase
$resolver->getArguments($request, $controller);
}
/**
* @expectedException \RuntimeException
*/
public function testIfExceptionIsThrownWhenMissingAnArgument()
{
$request = Request::create('/');
$controller = array($this, 'controllerWithFoo');
self::$resolver->getArguments($request, $controller);
}
/**
* @requires PHP 7.1
*/