Fixed Button::setParent() when already submitted

This commit is contained in:
Jules Pietri 2018-01-25 02:37:16 +01:00 committed by HeahDude
parent e52d977d12
commit 9f0c7bf549
2 changed files with 22 additions and 2 deletions

View File

@ -106,6 +106,10 @@ class Button implements \IteratorAggregate, FormInterface
*/
public function setParent(FormInterface $parent = null)
{
if ($this->submitted) {
throw new AlreadySubmittedException('You cannot set the parent of a submitted button');
}
$this->parent = $parent;
}

View File

@ -30,6 +30,20 @@ class ButtonTest extends TestCase
$this->factory = $this->getMockBuilder('Symfony\Component\Form\FormFactoryInterface')->getMock();
}
/**
* @expectedException \Symfony\Component\Form\Exception\AlreadySubmittedException
*/
public function testSetParentOnSubmittedButton()
{
$button = $this->getButtonBuilder('button')
->getForm()
;
$button->submit('');
$button->setParent($this->getFormBuilder('form')->getForm());
}
/**
* @dataProvider getDisabledStates
*/
@ -37,11 +51,13 @@ class ButtonTest extends TestCase
{
$form = $this->getFormBuilder('form')
->setDisabled($parentDisabled)
->getForm();
->getForm()
;
$button = $this->getButtonBuilder('button')
->setDisabled($buttonDisabled)
->getForm();
->getForm()
;
$button->setParent($form);