bug #28152 [Translation] fix perf of lint:xliff command (nicolas-grekas)
This PR was merged into the 4.1 branch.
Discussion
----------
[Translation] fix perf of lint:xliff command
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #27564
| License | MIT
| Doc PR | -
#27653 has been merged on master as an improvement, but the perf issue is a killer.
Our CI spends 1 minutes on just a few translation test cases.
Only 4.1 has this behavior. That's a bug.
Commits
-------
02c69b1658
[Translation] fix perf of lint:xliff command
This commit is contained in:
commit
9fae8f4609
|
@ -130,10 +130,10 @@ EOF
|
||||||
$document->schemaValidate(__DIR__.'/../Resources/schemas/xliff-core-1.2-strict.xsd');
|
$document->schemaValidate(__DIR__.'/../Resources/schemas/xliff-core-1.2-strict.xsd');
|
||||||
foreach (libxml_get_errors() as $xmlError) {
|
foreach (libxml_get_errors() as $xmlError) {
|
||||||
$errors[] = array(
|
$errors[] = array(
|
||||||
'line' => $xmlError->line,
|
'line' => $xmlError->line,
|
||||||
'column' => $xmlError->column,
|
'column' => $xmlError->column,
|
||||||
'message' => trim($xmlError->message),
|
'message' => trim($xmlError->message),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
libxml_clear_errors();
|
libxml_clear_errors();
|
||||||
|
|
|
@ -30,7 +30,7 @@ Jan-10-2006
|
||||||
-->
|
-->
|
||||||
<xsd:schema xmlns:xlf="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsd="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" targetNamespace="urn:oasis:names:tc:xliff:document:1.2" xml:lang="en">
|
<xsd:schema xmlns:xlf="urn:oasis:names:tc:xliff:document:1.2" xmlns:xsd="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified" targetNamespace="urn:oasis:names:tc:xliff:document:1.2" xml:lang="en">
|
||||||
<!-- Import for xml:lang and xml:space -->
|
<!-- Import for xml:lang and xml:space -->
|
||||||
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" schemaLocation="http://www.w3.org/2001/xml.xsd"/>
|
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" schemaLocation="../../Loader/schema/dic/xliff-core/xml.xsd"/>
|
||||||
<!-- Attributes Lists -->
|
<!-- Attributes Lists -->
|
||||||
<xsd:simpleType name="XTend">
|
<xsd:simpleType name="XTend">
|
||||||
<xsd:restriction base="xsd:string">
|
<xsd:restriction base="xsd:string">
|
||||||
|
|
Reference in New Issue