diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Cache] Accept only array in TagAwareAdapter::invalidateTags()

Browse Source
This commit is contained in:
Nicolas Grekas 2016-10-06 12:43:30 +02:00
parent 117bd4c305
commit a08acc721c
3 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
View File

@ -67,11 +67,8 @@ class TagAwareAdapter implements TagAwareAdapterInterface
/**
* {@inheritdoc}
*/
public function invalidateTags($tags)
public function invalidateTags(array $tags)
{
if (!is_array($tags)) {
$tags = array($tags);
}
foreach ($tags as $k => $tag) {
if ('' !== $tag && is_string($tag)) {
$tags[$k] = $tag.static::TAGS_PREFIX;

4
src/Symfony/Component/Cache/Adapter/TagAwareAdapterInterface.php
View File

@ -23,11 +23,11 @@ interface TagAwareAdapterInterface extends AdapterInterface
/**
* Invalidates cached items using tags.
*
* @param string|string[] $tags A tag or an array of tags to invalidate
* @param string[] $tags An array of tags to invalidate
*
* @return bool True on success
*
* @throws InvalidArgumentException When $tags is not valid
*/
public function invalidateTags($tags);
public function invalidateTags(array $tags);
}

8
src/Symfony/Component/Cache/Tests/Adapter/TagAwareAdapterTest.php
View File

@ -55,7 +55,7 @@ class TagAwareAdapterTest extends AdapterTestCase
$pool->save($i3->tag('foo')->tag('baz'));
$pool->save($foo);
$pool->invalidateTags('bar');
$pool->invalidateTags(array('bar'));
$this->assertFalse($pool->getItem('i0')->isHit());
$this->assertTrue($pool->getItem('i1')->isHit());
@ -63,7 +63,7 @@ class TagAwareAdapterTest extends AdapterTestCase
$this->assertTrue($pool->getItem('i3')->isHit());
$this->assertTrue($pool->getItem('foo')->isHit());
$pool->invalidateTags('foo');
$pool->invalidateTags(array('foo'));
$this->assertFalse($pool->getItem('i1')->isHit());
$this->assertFalse($pool->getItem('i3')->isHit());
@ -80,7 +80,7 @@ class TagAwareAdapterTest extends AdapterTestCase
$i = $pool->getItem('k');
$pool->save($i->tag('bar'));
$pool->invalidateTags('foo');
$pool->invalidateTags(array('foo'));
$this->assertTrue($pool->getItem('k')->isHit());
}
@ -93,7 +93,7 @@ class TagAwareAdapterTest extends AdapterTestCase
$pool->deleteItem('k');
$pool->save($pool->getItem('k'));
$pool->invalidateTags('foo');
$pool->invalidateTags(array('foo'));
$this->assertTrue($pool->getItem('k')->isHit());
}