diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #17807 [HttpFoundation] [Session] Removed unnecessary PHP version check (Calin Mihai Pristavu)

Browse Source 
This PR was merged into the 3.0 branch.

Discussion
----------

[HttpFoundation] [Session] Removed unnecessary PHP version check

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #17805
| License       | MIT

Fixes #17805

Commits
-------

c0e41f9 [HttpFoundation] [Session] Removed unnecessary PHP version check as minimum requirement is now 5.5.9
This commit is contained in:
Fabien Potencier 2016-02-15 17:52:28 +01:00
commit a14bcc65ac
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
View File

@ -182,12 +182,7 @@ class NativeSessionStorage implements SessionStorageInterface
public function regenerate($destroy = false, $lifetime = null)
{
// Cannot regenerate the session ID for non-active sessions.
if (PHP_VERSION_ID >= 50400 && \PHP_SESSION_ACTIVE !== session_status()) {
return false;
}
// Check if session ID exists in PHP 5.3
if (PHP_VERSION_ID < 50400 && '' === session_id()) {
if (\PHP_SESSION_ACTIVE !== session_status()) {
return false;
}