diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring

Browse Source
This commit is contained in:
Nicolas Grekas 2017-10-23 17:00:45 +02:00
parent dde192a3af
commit a4a0ae20ca
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
View File

@ -34,6 +34,7 @@ class AutowirePass extends AbstractRecursivePass
private $lastFailure;
private $throwOnAutowiringException;
private $autowiringExceptions = array();
private $strictMode;
/**
* @param bool $throwOnAutowireException Errors can be retrieved via Definition::getErrors()
@ -62,6 +63,7 @@ class AutowirePass extends AbstractRecursivePass
{
// clear out any possibly stored exceptions from before
$this->autowiringExceptions = array();
$this->strictMode = $container->hasParameter('container.autowiring.strict_mode') && $container->getParameter('container.autowiring.strict_mode');
try {
parent::process($container);
@ -290,7 +292,7 @@ class AutowirePass extends AbstractRecursivePass
return new TypedReference($this->types[$type], $type);
}
if (isset($this->types[$type])) {
if (!$this->strictMode && isset($this->types[$type])) {
$message = 'Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won\'t be supported in version 4.0.';
if ($aliasSuggestion = $this->getAliasesSuggestionForType($type = $reference->getType(), $deprecationMessage)) {
$message .= ' '.$aliasSuggestion;
@ -311,7 +313,9 @@ class AutowirePass extends AbstractRecursivePass
return $this->autowired[$type] ? new TypedReference($this->autowired[$type], $type) : null;
}
return $this->createAutowiredDefinition($type);
if (!$this->strictMode) {
return $this->createAutowiredDefinition($type);
}
}
/**