minor #24106 [DependencyInjection] Don't use return on Assert::markTestSkipped (derrabus)
This PR was merged into the 3.3 branch.
Discussion
----------
[DependencyInjection] Don't use return on Assert::markTestSkipped
| Q | A
| ------------- | ---
| Branch? | 3.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | N/A
Removed an unnecessary return statement. `Assert::markTestSkipped()` will always throw an exception, so there's no need for a return statement here. And even if that method had a return value: A unit test is not supposed to return anything.
Commits
-------
9cadeb8af2
Don't use return on Assert::markTestSkipped.
This commit is contained in:
commit
a4a87ac3a3
@ -51,7 +51,7 @@ class IniFileLoaderTest extends TestCase
|
|||||||
public function testTypeConversionsWithNativePhp($key, $value, $supported)
|
public function testTypeConversionsWithNativePhp($key, $value, $supported)
|
||||||
{
|
{
|
||||||
if (defined('HHVM_VERSION_ID')) {
|
if (defined('HHVM_VERSION_ID')) {
|
||||||
return $this->markTestSkipped();
|
$this->markTestSkipped();
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!$supported) {
|
if (!$supported) {
|
||||||
|
Reference in New Issue
Block a user