Merge branch '3.4' into 4.1

* 3.4:
  typo
  add a test case
  [Form] Handle all case variants of "nan" when parsing a number
This commit is contained in:
Nicolas Grekas 2018-11-30 09:55:04 +01:00
commit a4bc4ac0ce
3 changed files with 11 additions and 11 deletions

View File

@ -146,7 +146,7 @@ class NumberToLocalizedStringTransformer implements DataTransformerInterface
return;
}
if ('NaN' === $value) {
if (\in_array($value, array('NaN', 'NAN', 'nan'), true)) {
throw new TransformationFailedException('"NaN" is not a valid number');
}

View File

@ -514,24 +514,24 @@ class NumberToLocalizedStringTransformerTest extends TestCase
/**
* @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
* @dataProvider nanRepresentationProvider
*
* @see https://github.com/symfony/symfony/issues/3161
*/
public function testReverseTransformDisallowsNaN()
public function testReverseTransformDisallowsNaN($nan)
{
$transformer = new NumberToLocalizedStringTransformer();
$transformer->reverseTransform('NaN');
$transformer->reverseTransform($nan);
}
/**
* @expectedException \Symfony\Component\Form\Exception\TransformationFailedException
*/
public function testReverseTransformDisallowsNaN2()
public function nanRepresentationProvider()
{
$transformer = new NumberToLocalizedStringTransformer();
$transformer->reverseTransform('nan');
return array(
array('nan'),
array('NaN'), // see https://github.com/symfony/symfony/issues/3161
array('NAN'),
);
}
/**

View File

@ -112,7 +112,7 @@ interface ExecutionContextInterface
* Returns the currently validated object.
*
* If the validator is currently validating a class constraint, the
* object of that class is returned. If it is a validating a property or
* object of that class is returned. If it is validating a property or
* getter constraint, the object that the property/getter belongs to is
* returned.
*