diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CS Fixes: Not double split with one array argument

Browse Source 
Keep to use the same CS in all the Symfony code base.

Use:
```php
$resolver->setDefaults([
    'compound' => false
]);
```

Instead of:
```php
$resolver->setDefaults(
    [
        'compound' => false,
    ]
);
```

Keep the double split when the method has two or more arguments.

I miss a PSR with this rule.
This commit is contained in:
rubenrua 2019-04-10 18:00:48 +02:00 committed by rubenrua
parent 84814be4c7
commit a56bf552ad
6 changed files with 74 additions and 92 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Symfony/Bundle/SecurityBundle/Tests/Functional/UserPasswordEncoderCommandTest.php
View File

@ -126,14 +126,12 @@ class UserPasswordEncoderCommandTest extends WebTestCase
public function testEncodePasswordEmptySaltOutput() public function testEncodePasswordEmptySaltOutput()
{ {
$this->passwordEncoderCommandTester->execute( $this->passwordEncoderCommandTester->execute([
[
'command' => 'security:encode-password', 'command' => 'security:encode-password',
'password' => 'p@ssw0rd', 'password' => 'p@ssw0rd',
'user-class' => 'Symfony\Component\Security\Core\User\User', 'user-class' => 'Symfony\Component\Security\Core\User\User',
'--empty-salt' => true, '--empty-salt' => true,
] ]);
);
$this->assertContains('Password encoding succeeded', $this->passwordEncoderCommandTester->getDisplay()); $this->assertContains('Password encoding succeeded', $this->passwordEncoderCommandTester->getDisplay());
$this->assertContains(' Encoded password p@ssw0rd', $this->passwordEncoderCommandTester->getDisplay()); $this->assertContains(' Encoded password p@ssw0rd', $this->passwordEncoderCommandTester->getDisplay());

6
src/Symfony/Component/Form/Extension/Core/Type/DateIntervalType.php
View File

@ -205,8 +205,7 @@ class DateIntervalType extends AbstractType
})); }));
}; };
$resolver->setDefaults( $resolver->setDefaults([
[
'with_years' => true, 'with_years' => true,
'with_months' => true, 'with_months' => true,
'with_days' => true, 'with_days' => true,
@ -235,8 +234,7 @@ class DateIntervalType extends AbstractType
'compound' => $compound, 'compound' => $compound,
'empty_data' => $emptyData, 'empty_data' => $emptyData,
'labels' => [], 'labels' => [],
] ]);
);
$resolver->setNormalizer('placeholder', $placeholderNormalizer); $resolver->setNormalizer('placeholder', $placeholderNormalizer);
$resolver->setNormalizer('labels', $labelsNormalizer); $resolver->setNormalizer('labels', $labelsNormalizer);

6
src/Symfony/Component/Form/Tests/ChoiceList/Factory/DefaultChoiceListFactoryTest.php
View File

@ -144,12 +144,10 @@ class DefaultChoiceListFactoryTest extends TestCase
public function testCreateFromChoicesGrouped() public function testCreateFromChoicesGrouped()
{ {
$list = $this->factory->createListFromChoices( $list = $this->factory->createListFromChoices([
[
'Group 1' => ['A' => $this->obj1, 'B' => $this->obj2], 'Group 1' => ['A' => $this->obj1, 'B' => $this->obj2],
'Group 2' => ['C' => $this->obj3, 'D' => $this->obj4], 'Group 2' => ['C' => $this->obj3, 'D' => $this->obj4],
] ]);
);
$this->assertObjectListWithGeneratedValues($list); $this->assertObjectListWithGeneratedValues($list);
} }

18
src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
View File

@ -531,13 +531,11 @@ class OptionsResolverTest extends TestCase
$this->resolver->setDefined('foo'); $this->resolver->setDefined('foo');
$this->resolver->setAllowedTypes('foo', 'int[][]'); $this->resolver->setAllowedTypes('foo', 'int[][]');
$this->resolver->resolve( $this->resolver->resolve([
[
'foo' => [ 'foo' => [
[1.2], [1.2],
], ],
] ]);
);
} }
/** /**
@ -1598,13 +1596,11 @@ class OptionsResolverTest extends TestCase
1, 2, 1, 2,
], ],
], ],
], $this->resolver->resolve( ], $this->resolver->resolve([
[
'foo' => [ 'foo' => [
[1, 2], [1, 2],
], ],
] ]));
));
} }
public function testNested2Arrays() public function testNested2Arrays()
@ -1644,8 +1640,7 @@ class OptionsResolverTest extends TestCase
$this->resolver->setDefined('foo'); $this->resolver->setDefined('foo');
$this->resolver->setAllowedTypes('foo', 'float[][][][]'); $this->resolver->setAllowedTypes('foo', 'float[][][][]');
$this->resolver->resolve( $this->resolver->resolve([
[
'foo' => [ 'foo' => [
[ [
[ [
@ -1653,8 +1648,7 @@ class OptionsResolverTest extends TestCase
], ],
], ],
], ],
] ]);
);
} }
/** /**

6
src/Symfony/Component/Translation/Tests/Dumper/YamlFileDumperTest.php
View File

@ -20,8 +20,7 @@ class YamlFileDumperTest extends TestCase
public function testTreeFormatCatalogue() public function testTreeFormatCatalogue()
{ {
$catalogue = new MessageCatalogue('en'); $catalogue = new MessageCatalogue('en');
$catalogue->add( $catalogue->add([
[
'foo.bar1' => 'value1', 'foo.bar1' => 'value1',
'foo.bar2' => 'value2', 'foo.bar2' => 'value2',
]); ]);
@ -34,8 +33,7 @@ class YamlFileDumperTest extends TestCase
public function testLinearFormatCatalogue() public function testLinearFormatCatalogue()
{ {
$catalogue = new MessageCatalogue('en'); $catalogue = new MessageCatalogue('en');
$catalogue->add( $catalogue->add([
[
'foo.bar1' => 'value1', 'foo.bar1' => 'value1',
'foo.bar2' => 'value2', 'foo.bar2' => 'value2',
]); ]);

12
src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php
View File

@ -55,12 +55,10 @@ class ChoiceValidatorTest extends ConstraintValidatorTestCase
{ {
$this->validator->validate( $this->validator->validate(
null, null,
new Choice( new Choice([
[
'choices' => ['foo', 'bar'], 'choices' => ['foo', 'bar'],
'strict' => true, 'strict' => true,
] ])
)
); );
$this->assertNoViolation(); $this->assertNoViolation();
@ -102,14 +100,12 @@ class ChoiceValidatorTest extends ConstraintValidatorTestCase
public function testValidChoiceCallbackClosure() public function testValidChoiceCallbackClosure()
{ {
$constraint = new Choice( $constraint = new Choice([
[
'strict' => true, 'strict' => true,
'callback' => function () { 'callback' => function () {
return ['foo', 'bar']; return ['foo', 'bar'];
}, },
] ]);
);
$this->validator->validate('bar', $constraint); $this->validator->validate('bar', $constraint);