bug #9970 [CssSelector] fixed numeric attribute issue (jfsimon)

This PR was merged into the 2.3 branch.

Discussion
----------

[CssSelector] fixed numeric attribute issue

This PR adds a cast from number to string when parsing a numeric attribute value.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9968

Commits
-------

613535a [CssSelector] fixed numeric attribute issue
This commit is contained in:
Fabien Potencier 2014-01-07 21:11:44 +01:00
commit a5b4aad45b
2 changed files with 6 additions and 0 deletions

View File

@ -378,6 +378,11 @@ class Parser implements ParserInterface
$stream->skipWhitespace();
$value = $stream->getNext();
if ($value->isNumber()) {
// if the value is a number, it's casted into a string
$value = new Token(Token::TYPE_STRING, (string) $value->getValue(), $value->getPosition());
}
if (!($value->isIdentifier() || $value->isString())) {
throw SyntaxErrorException::unexpectedToken('string or identifier', $value);
}

View File

@ -133,6 +133,7 @@ class ParserTest extends \PHPUnit_Framework_TestCase
array('div#foobar', array('Hash[Element[div]#foobar]')),
array('div:not(div.foo)', array('Negation[Element[div]:not(Class[Element[div].foo])]')),
array('td ~ th', array('CombinedSelector[Element[td] ~ Element[th]]')),
array('.foo[data-bar][data-baz=0]', array("Attribute[Attribute[Class[Element[*].foo][data-bar]][data-baz = '0']]")),
);
}